Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(139)

Issue 1182603002: Reland of Remove GetAttributes from the mix to avoid another virtual dispatch. (Closed)

Created:
5 years, 6 months ago by Toon Verwaest
Modified:
5 years, 6 months ago
Reviewers:
Igor Sheludko
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Reland of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #1 id:1 of https://codereview.chromium.org/1179933002/) Reason: This didn't break anything. Original issue's description: > Revert of Remove GetAttributes from the mix to avoid another virtual dispatch. (patchset #2 id:40001 of https://codereview.chromium.org/1175973002/) > > Reason for revert: > It broke webkit_unit_tests > > Original issue's description: > > Remove GetAttributes from the mix to avoid another virtual dispatch. > > > > BUG=chromium:495949, v8:4137 > > LOG=n > > > > Committed: https://crrev.com/2269b8b5a696bf4eef13590093151bff624d4175 > > Cr-Commit-Position: refs/heads/master@{#28953} > > TBR=verwaest@chromium.org > NOPRESUBMIT=true > NOTREECHECKS=true > NOTRY=true > BUG=chromium:495949, v8:4137 > > Committed: https://crrev.com/ae639d2ad646237e2f413259a0f116845ef96440 > Cr-Commit-Position: refs/heads/master@{#28958} TBR=ishell@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=chromium:495949, v8:4137 Committed: https://crrev.com/360e0204087c458db1d7e7635b38b7430bfde873 Cr-Commit-Position: refs/heads/master@{#28966}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -109 lines) Patch
M src/elements.h View 2 chunks +2 lines, -14 lines 0 comments Download
M src/elements.cc View 11 chunks +32 lines, -90 lines 0 comments Download
M src/lookup-inl.h View 1 chunk +1 line, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Toon Verwaest
Created Revert of Revert of Remove GetAttributes from the mix to avoid another virtual dispatch.
5 years, 6 months ago (2015-06-11 20:16:54 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182603002/1
5 years, 6 months ago (2015-06-11 20:17:10 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 20:17:30 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-11 20:17:46 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/360e0204087c458db1d7e7635b38b7430bfde873
Cr-Commit-Position: refs/heads/master@{#28966}

Powered by Google App Engine
This is Rietveld 408576698