Clean up uses of X::CheckedHandle where X::Cast or X::Handle is sufficient.

runtime/vm/object.cc

 // Copyright (c) 2012, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 #include "vm/object.h"
 
 #include "include/dart_api.h"
 #include "platform/assert.h"
 #include "vm/assembler.h"
 #include "vm/bigint_operations.h"
@@ skipping 5767 matching lines @@
       return obj.raw();
     }
   }
   return Object::null();
 }
 
 
 RawClass* Library::LookupClass(const String& name) const {
   Object& obj = Object::Handle(LookupObject(name));
   if (!obj.IsNull() && obj.IsClass()) {
-    return Class::CheckedHandle(obj.raw()).raw();
+    return Class::Cast(obj).raw();
   }
   return Class::null();
 }
 
 
 RawClass* Library::LookupLocalClass(const String& name) const {
   Object& obj = Object::Handle(LookupLocalObject(name));
   if (!obj.IsNull() && obj.IsClass()) {
-    return Class::CheckedHandle(obj.raw()).raw();
+    return Class::Cast(obj).raw();
   }
   return Class::null();
 }
 
 
 RawClass* Library::LookupClassAllowPrivate(const String& name) const {
   // See if the class is available in this library or in the top level
   // scope of any imported library.
   Isolate* isolate = Isolate::Current();
   const Class& cls = Class::Handle(isolate, LookupClass(name));
@@ skipping 431 matching lines @@
   intptr_t len = OS::SNPrint(NULL, 0, kFormat, name.ToCString()) + 1;
   char* chars = Isolate::Current()->current_zone()->Alloc<char>(len);
   OS::SNPrint(chars, len, kFormat, name.ToCString());
   return chars;
 }
 
 
 RawLibrary* LibraryPrefix::GetLibrary(int index) const {
   if ((index >= 0) || (index < num_imports())) {
     const Array& imports = Array::Handle(this->imports());
-    const Namespace& import = Namespace::CheckedHandle(imports.At(index));
+    Namespace& import = Namespace::Handle();
+    import ^= imports.At(index);
     return import.library();
   }
   return Library::null();
 }
 
 
 bool LibraryPrefix::ContainsLibrary(const Library& library) const {
   intptr_t num_current_imports = num_imports();
   if (num_current_imports > 0) {
     Library& lib = Library::Handle();
@@ skipping 511 matching lines @@
     chars[index] = '\0';
     return chars;
   }
 }
 
 
 RawString* LocalVarDescriptors::GetName(intptr_t var_index) const {
   ASSERT(var_index < Length());
   const Array& names = Array::Handle(raw_ptr()->names_);
   ASSERT(Length() == names.Length());
-  const String& name = String::CheckedHandle(names.At(var_index));
+  String& name = String::Handle();
+  name ^= names.At(var_index);
   return name.raw();
 }
 
 
 void LocalVarDescriptors::SetVar(intptr_t var_index,
                                  const String& name,
                                  RawLocalVarDescriptors::VarInfo* info) const {
   ASSERT(var_index < Length());
   const Array& names = Array::Handle(raw_ptr()->names_);
   ASSERT(Length() == names.Length());
@@ skipping 256 matching lines @@
 
 intptr_t Code::Comments::Length() const {
   if (comments_.IsNull()) {
     return 0;
   }
   return comments_.Length() / kNumberOfEntries;
 }
 
 
 intptr_t Code::Comments::PCOffsetAt(intptr_t idx) const {
-  return Smi::CheckedHandle(
-      comments_.At(idx * kNumberOfEntries + kPCOffsetEntry)).Value();
+  Smi& result = Smi::Handle();
+  result ^= comments_.At(idx * kNumberOfEntries + kPCOffsetEntry);
+  return result.Value();
 }
 
 
 void Code::Comments::SetPCOffsetAt(intptr_t idx, intptr_t pc)  {
   comments_.SetAt(idx * kNumberOfEntries + kPCOffsetEntry,
                   Smi::Handle(Smi::New(pc)));
 }
 
 
-const String& Code::Comments::CommentAt(intptr_t idx) const {
-  return String::CheckedHandle(
-      comments_.At(idx * kNumberOfEntries + kCommentEntry));
+RawString* Code::Comments::CommentAt(intptr_t idx) const {
+  String& result = String::Handle();
+  result ^= comments_.At(idx * kNumberOfEntries + kCommentEntry);
+  return result.raw();
 }
 
 
 void Code::Comments::SetCommentAt(intptr_t idx, const String& comment) {
   comments_.SetAt(idx * kNumberOfEntries + kCommentEntry, comment);
 }
 
 
 Code::Comments::Comments(const Array& comments)
     : comments_(comments) {
@@ skipping 5340 matching lines @@
   }
   return result.raw();
 }
 
 
 const char* WeakProperty::ToCString() const {
   return "_WeakProperty";
 }
 
 }  // namespace dart