Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1199)

Unified Diff: content/renderer/browser_plugin/browser_plugin_bindings.h

Issue 11826005: Browser Plugin: Implement BrowserPluginObserver. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/browser_plugin/browser_plugin_bindings.h
diff --git a/content/renderer/browser_plugin/browser_plugin_bindings.h b/content/renderer/browser_plugin/browser_plugin_bindings.h
index 43bd4c2a502cbfeaa412c42c78afc354d5fde7c0..fce44fcb098d692639a6de97b37e6d113d458843 100644
--- a/content/renderer/browser_plugin/browser_plugin_bindings.h
+++ b/content/renderer/browser_plugin/browser_plugin_bindings.h
@@ -12,7 +12,7 @@
namespace content {
-class BrowserPlugin;
+class BrowserPluginImpl;
class BrowserPluginMethodBinding;
class BrowserPluginPropertyBinding;
@@ -29,12 +29,12 @@ class BrowserPluginBindings {
base::WeakPtr<BrowserPluginBindings> message_channel;
};
- explicit BrowserPluginBindings(BrowserPlugin* instance);
+ explicit BrowserPluginBindings(BrowserPluginImpl* instance);
~BrowserPluginBindings();
NPObject* np_object() const { return np_object_; }
- BrowserPlugin* instance() const { return instance_; }
+ BrowserPluginImpl* instance() const { return instance_; }
bool HasMethod(NPIdentifier name) const;
@@ -48,8 +48,12 @@ class BrowserPluginBindings {
NPIdentifier name,
const NPVariant* variant);
bool GetProperty(NPIdentifier name, NPVariant* result);
+
+ void AddMethodBinding(BrowserPluginMethodBinding* method_binding);
sadrul 2013/01/09 15:21:54 Comment on ownership/lifetime
Fady Samuel 2013/01/09 17:41:24 Done.
+ void AddPropertyBinding(BrowserPluginPropertyBinding* property_binding);
+
private:
- BrowserPlugin* instance_;
+ BrowserPluginImpl* instance_;
// The NPObject we use to expose postMessage to JavaScript.
BrowserPluginNPObject* np_object_;

Powered by Google App Engine
This is Rietveld 408576698