Browser Plugin: Implement BrowserPluginObserver.

content/renderer/browser_plugin/browser_plugin_impl.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
-#ifndef  CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
-#define  CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
-
-#include "third_party/WebKit/Source/WebKit/chromium/public/WebPlugin.h"
+#ifndef  CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_IMPL_H_
+#define  CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_IMPL_H_
 
 #include "base/memory/scoped_ptr.h"
 #include "base/memory/weak_ptr.h"
+#include "base/observer_list.h"
 #include "base/process_util.h"
 #include "base/sequenced_task_runner_helpers.h"
 #if defined(OS_WIN)
 #include "base/shared_memory.h"
 #endif
+#include "content/public/renderer/browser_plugin/browser_plugin.h"
 #include "content/renderer/browser_plugin/browser_plugin_backing_store.h"
 #include "content/renderer/browser_plugin/browser_plugin_bindings.h"
 #include "content/renderer/render_view_impl.h"
 #include "third_party/WebKit/Source/WebKit/chromium/public/WebDragStatus.h"
+#include "third_party/WebKit/Source/WebKit/chromium/public/WebPlugin.h"
 
 struct BrowserPluginHostMsg_AutoSize_Params;
 struct BrowserPluginHostMsg_ResizeGuest_Params;
 struct BrowserPluginMsg_LoadCommit_Params;
 struct BrowserPluginMsg_UpdateRect_Params;
 
 namespace content {
 
 class BrowserPluginManager;
+class BrowserPluginObserver;
 class MockBrowserPlugin;
 
-class CONTENT_EXPORT BrowserPlugin :
-    NON_EXPORTED_BASE(public WebKit::WebPlugin) {
+class CONTENT_EXPORT BrowserPluginImpl :
+    NON_EXPORTED_BASE(public WebKit::WebPlugin),
+    public BrowserPlugin {
  public:
   RenderViewImpl* render_view() const { return render_view_.get(); }
 
   bool OnMessageReceived(const IPC::Message& msg);
 
   // Update Browser Plugin's DOM Node attribute |attribute_name| with the value
   // |attribute_value|.
   void UpdateDOMAttribute(const std::string& attribute_name,
                           const std::string& attribute_value);
 
@@ skipping 67 matching lines @@
   void EnableCompositing(bool enable);
 
   // Returns true if |point| lies within the bounds of the plugin rectangle.
   // Not OK to use this function for making security-sensitive decision since it
   // can return false positives when the plugin has rotation transformation
   // applied.
   bool InBounds(const gfx::Point& point) const;
 
   gfx::Point ToLocalCoordinates(const gfx::Point& point) const;
 
+  // BrowserPlugin implementation.
+

[sadrul, 2013/01/09 15:21:54]

remove newline

[Fady Samuel, 2013/01/09 17:41:24]

Done.

+  virtual void AddMethodBinding(
+      BrowserPluginMethodBinding* method_binding) OVERRIDE;
+  virtual void AddPropertyBinding(
+      BrowserPluginPropertyBinding* method_binding) OVERRIDE;
+  virtual bool Send(IPC::Message* message) OVERRIDE;

[sadrul, 2013/01/09 15:21:54]

It might make more sense to group the IPC::Sender override seperately, under a
'IPC::Sender implementation.' comment (this approach is followed in the ui code,
but I am not sure about non-ui code)

[Fady Samuel, 2013/01/09 17:41:24]

Done.

+  virtual void RequestMessage(uint32 message_id) OVERRIDE;
+
   // WebKit::WebPlugin implementation.
   virtual WebKit::WebPluginContainer* container() const OVERRIDE;
   virtual bool initialize(WebKit::WebPluginContainer* container) OVERRIDE;
   virtual void destroy() OVERRIDE;
   virtual NPObject* scriptableObject() OVERRIDE;
   virtual bool supportsKeyboardFocus() const OVERRIDE;
   virtual bool canProcessDrag() const OVERRIDE;
   virtual void paint(
       WebKit::WebCanvas* canvas,
       const WebKit::WebRect& rect) OVERRIDE;
@@ skipping 19 matching lines @@
   virtual void didFinishLoading() OVERRIDE;
   virtual void didFailLoading(const WebKit::WebURLError& error) OVERRIDE;
   virtual void didFinishLoadingFrameRequest(
       const WebKit::WebURL& url,
       void* notify_data) OVERRIDE;
   virtual void didFailLoadingFrameRequest(
       const WebKit::WebURL& url,
       void* notify_data,
       const WebKit::WebURLError& error) OVERRIDE;
  private:
-  friend class base::DeleteHelper<BrowserPlugin>;
+  friend class base::DeleteHelper<BrowserPluginImpl>;
   // Only the manager is allowed to create a BrowserPlugin.
   friend class BrowserPluginManagerImpl;
+  friend class BrowserPluginObserver;
   friend class MockBrowserPluginManager;
 
   // For unit/integration tests.
   friend class MockBrowserPlugin;
 
   // A BrowserPlugin object is a controller that represents an instance of a

[sadrul, 2013/01/09 15:21:54]

Update comment

[Fady Samuel, 2013/01/09 17:41:24]

Done.

   // browser plugin within the embedder renderer process. Each BrowserPlugin
   // within a process has a unique instance_id that is used to route messages
   // to it. It takes in a RenderViewImpl that it's associated with along
   // with the frame within which it lives and the initial attributes assigned
   // to it on creation.
-  BrowserPlugin(
+  BrowserPluginImpl(
       int instance_id,
       RenderViewImpl* render_view,
       WebKit::WebFrame* frame,
       const WebKit::WebPluginParams& params);
 
-  virtual ~BrowserPlugin();
+  virtual ~BrowserPluginImpl();
+
+  // Add and remove observers for filtering IPC messages.  Clients must be sure

[sadrul, 2013/01/09 15:21:54]

single space after the dot

[Fady Samuel, 2013/01/09 17:41:24]

Done.

+  // to remove the observer before they go away.
+  void AddObserver(BrowserPluginObserver* observer);
+  void RemoveObserver(BrowserPluginObserver* observer);
 
   int width() const { return plugin_rect_.width(); }
   int height() const { return plugin_rect_.height(); }
   int instance_id() const { return instance_id_; }
   int render_view_routing_id() const { return render_view_routing_id_; }
   BrowserPluginManager* browser_plugin_manager() const {
     return browser_plugin_manager_;
   }
 
   // Virtual to allow for mocking in tests.
@@ skipping 112 matching lines @@
   WebCursor cursor_;
 
   gfx::Size last_view_size_;
   bool size_changed_in_flight_;
 
   // BrowserPlugin outlives RenderViewImpl in Chrome Apps and so we need to
   // store the BrowserPlugin's BrowserPluginManager in a member variable to
   // avoid accessing the RenderViewImpl.
   scoped_refptr<BrowserPluginManager> browser_plugin_manager_;
 
+  // A list of observers that filter messages.  Weak references.

[sadrul, 2013/01/09 15:21:54]

ditto

[Fady Samuel, 2013/01/09 17:41:24]

Done.

+  ObserverList<BrowserPluginObserver> observers_;
+
   // Important: Do not add more history state here.
   // We strongly discourage storing additional history state (such as page IDs)
   // in the embedder process, at the risk of having incorrect information that
   // can lead to broken back/forward logic in apps.
   // It's also important that this state does not get modified by any logic in
   // the embedder process. It should only be updated in response to navigation
   // events in the guest.  No assumptions should be made about how the index
   // will change after a navigation (e.g., for back, forward, or go), because
   // the changes are not always obvious.  For example, there is a maximum
   // number of entries and earlier ones will automatically be pruned.
   int current_nav_entry_index_;
   int nav_entry_count_;
 
   // Used for HW compositing.
   bool compositing_enabled_;
 
-  DISALLOW_COPY_AND_ASSIGN(BrowserPlugin);
+  DISALLOW_COPY_AND_ASSIGN(BrowserPluginImpl);
 };
 
 }  // namespace content
 
-#endif  // CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_H_
+#endif  // CONTENT_RENDERER_BROWSER_PLUGIN_BROWSER_PLUGIN_IMPL_H_