Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(26)

Issue 1182563002: Remove redundant Paint.setARGB in favor of assigning to Paint.color. (Closed)

Created:
5 years, 6 months ago by Matt Perry
Modified:
5 years, 6 months ago
CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org
Base URL:
git@github.com:/domokit/mojo.git@master
Target Ref:
refs/heads/master
Project:
mojo
Visibility:
Public.

Description

Remove redundant Paint.setARGB in favor of assigning to Paint.color. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/961913cb10d9bb0eeeb44895e4bf2517b2a59d4f

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -16 lines) Patch
M sky/engine/core/painting/Paint.h View 1 chunk +0 lines, -4 lines 0 comments Download
M sky/engine/core/painting/Paint.idl View 1 chunk +0 lines, -2 lines 0 comments Download
M sky/examples/game/lib/sprite.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M sky/examples/raw/circle.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/raw/custom_paint_without_element.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/raw/draw_picture_into_canvas.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/raw/hello_world.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/raw/paint_element_into_displaylist.sky View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/raw/spinning_arabic.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/raw/spinning_image.dart View 1 chunk +1 line, -1 line 0 comments Download
M sky/examples/raw/spinning_square.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (2 generated)
Matt Perry
5 years, 6 months ago (2015-06-11 18:44:11 UTC) #2
abarth-chromium
lgtm
5 years, 6 months ago (2015-06-11 19:34:49 UTC) #4
Matt Perry
Committed patchset #1 (id:1) manually as 961913cb10d9bb0eeeb44895e4bf2517b2a59d4f (presubmit successful).
5 years, 6 months ago (2015-06-11 19:43:56 UTC) #5
eseidel
5 years, 6 months ago (2015-06-11 19:44:01 UTC) #6
Message was sent while issue was closed.
lgtm

Gorgeous.

Powered by Google App Engine
This is Rietveld 408576698