Issue 1182543002: Remove bogus CHECK in set_isolate.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1182543002: Remove bogus CHECK in set_isolate. (Closed)

Created:
5 years, 6 months ago by eseidel

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Remove bogus CHECK in set_isolate. This was added in 22da76be1ee64120f69ed35d6f21c85c31df08b6 but breaks all navigation (which is sadly only tested by our demo site). R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/bb70796b3f35ab5793e02d0a7a9ae02bcbb74506

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+0 lines, -1 line)			Patch
	M	sky/engine/tonic/dart_state.cc	View		1 chunk	+0 lines, -1 line	0 comments	Download

Total messages: 2 (0 generated)

eseidel

5 years, 6 months ago (2015-06-11 18:05:41 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
bb70796b3f35ab5793e02d0a7a9ae02bcbb74506 (presubmit successful).