Add managed policies for Native Messaging

chrome/browser/extensions/api/messaging/native_messaging_policy_handler_unittest.cc

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/extensions/api/messaging/native_messaging_policy_handler.h"
+
+#include "base/prefs/pref_value_map.h"
+#include "chrome/browser/extensions/policy_handlers.h"
+#include "chrome/common/pref_names.h"
+#include "components/policy/core/browser/policy_error_map.h"
+#include "components/policy/core/common/policy_map.h"
+#include "policy/policy_constants.h"
+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace extensions {
+
+const char kTestPref[] = "unit_test.test_pref";
+
+TEST(NativeMessagingHostListPolicyHandlerTest, CheckPolicySettings) {
+  base::ListValue list;
+  policy::PolicyMap policy_map;
+  policy::PolicyErrorMap errors;
+  NativeMessagingHostListPolicyHandler handler(
+      policy::key::kNativeMessagingBlacklist, kTestPref, true);
+
+  policy_map.Set(policy::key::kNativeMessagingBlacklist,
+                 policy::POLICY_LEVEL_MANDATORY,
+                 policy::POLICY_SCOPE_USER,
+                 list.DeepCopy(),
+                 NULL);
+  errors.Clear();
+  EXPECT_TRUE(handler.CheckPolicySettings(policy_map, &errors));
+  EXPECT_TRUE(errors.empty());

[not at google - send to devlin, 2013/12/28 04:55:51]

fwiw, rather than this pattern of constantly clearing the errors, I usually
prefer a safer and more obviously correct sequence of assertions in the form:

// setup...
{
  policy::PolicyErrorMap errors;
  CheckPolicySettings(&errors);
  EXPECT_TRUE(errors.empty());
}

etc. but, up to you.

[Sergey Ulanov, 2014/01/06 23:21:55]

Done.

+
+  list.Append(
+      base::Value::CreateStringValue("test.a.b"));
+  policy_map.Set(policy::key::kNativeMessagingBlacklist,
+                 policy::POLICY_LEVEL_MANDATORY,
+                 policy::POLICY_SCOPE_USER,
+                 list.DeepCopy(),
+                 NULL);
+  errors.Clear();
+  EXPECT_TRUE(handler.CheckPolicySettings(policy_map, &errors));
+  EXPECT_TRUE(errors.empty());
+
+  list.Append(base::Value::CreateStringValue("*"));
+  policy_map.Set(policy::key::kNativeMessagingBlacklist,
+                 policy::POLICY_LEVEL_MANDATORY,
+                 policy::POLICY_SCOPE_USER,
+                 list.DeepCopy(),
+                 NULL);
+  errors.Clear();
+  EXPECT_TRUE(handler.CheckPolicySettings(policy_map, &errors));
+  EXPECT_TRUE(errors.empty());
+
+  list.Append(base::Value::CreateStringValue("invalid Name"));
+  policy_map.Set(policy::key::kNativeMessagingBlacklist,
+                 policy::POLICY_LEVEL_MANDATORY,
+                 policy::POLICY_SCOPE_USER,
+                 list.DeepCopy(),
+                 NULL);
+  errors.Clear();
+  EXPECT_TRUE(handler.CheckPolicySettings(policy_map, &errors));
+  EXPECT_FALSE(errors.empty());
+  EXPECT_FALSE(
+      errors.GetErrors(policy::key::kNativeMessagingBlacklist).empty());

[not at google - send to devlin, 2013/12/28 04:55:51]

can you actually assert that the content here is what you expect? something
along the lines of

{
  PolcyErrorMap errors;
  CheckPolicySerttings(&errors);
  EXPECT_EQ(kTheErrorThatYouExpect, errors.GetErrors(..));
}

[Sergey Ulanov, 2014/01/06 23:21:55]

The error message is localized, so I don't think it would be right to check the
message here.

+}
+
+TEST(NativeMessagingHostListPolicyHandlerTest, ApplyPolicySettings) {
+  base::ListValue policy;
+  base::ListValue expected;
+  policy::PolicyMap policy_map;
+  PrefValueMap prefs;
+  base::Value* value = NULL;
+  NativeMessagingHostListPolicyHandler handler(
+      policy::key::kNativeMessagingBlacklist, kTestPref, false);
+
+  policy.Append(
+      base::Value::CreateStringValue("com.example.test"));
+  expected.Append(
+      base::Value::CreateStringValue("com.example.test"));

[not at google - send to devlin, 2013/12/28 04:55:51]

new StringValue

[Sergey Ulanov, 2014/01/06 23:21:55]

Done.

+
+  policy_map.Set(policy::key::kNativeMessagingBlacklist,
+                 policy::POLICY_LEVEL_MANDATORY,
+                 policy::POLICY_SCOPE_USER,
+                 policy.DeepCopy(),
+                 NULL);
+  handler.ApplyPolicySettings(policy_map, &prefs);
+  EXPECT_TRUE(prefs.GetValue(kTestPref, &value));
+  EXPECT_TRUE(base::Value::Equals(&expected, value));
+

[not at google - send to devlin, 2013/12/28 04:55:51]

would it be useful to test the wildcard in here somewhere?

[Sergey Ulanov, 2014/01/06 23:21:55]

Done.

+  policy.Append(base::Value::CreateStringValue("invalid Name"));
+  policy_map.Set(policy::key::kNativeMessagingBlacklist,
+                 policy::POLICY_LEVEL_MANDATORY,
+                 policy::POLICY_SCOPE_USER,
+                 policy.DeepCopy(),
+                 NULL);
+  handler.ApplyPolicySettings(policy_map, &prefs);
+  EXPECT_TRUE(prefs.GetValue(kTestPref, &value));
+  EXPECT_TRUE(base::Value::Equals(&expected, value));
+}
+
+}  // namespace extensions