Reset browser.check_default_browser to true when Chrome is the user's default browser

chrome/browser/ui/startup/default_browser_prompt.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/startup/default_browser_prompt.h"
 
 #include "base/memory/weak_ptr.h"
 #include "base/message_loop/message_loop.h"
 #include "base/metrics/histogram.h"
 #include "base/prefs/pref_registry_simple.h"
 #include "base/prefs/pref_service.h"
 #include "base/version.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/first_run/first_run.h"
 #include "chrome/browser/infobars/infobar_service.h"
 #include "chrome/browser/profiles/profile.h"
+#include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/shell_integration.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/browser_finder.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_version_info.h"
 #include "chrome/common/pref_names.h"
 #include "chrome/grit/chromium_strings.h"
 #include "chrome/grit/generated_resources.h"
 #include "chrome/installer/util/master_preferences.h"
 #include "chrome/installer/util/master_preferences_constants.h"
@@ skipping 160 matching lines @@
     return;
 
   DefaultBrowserInfoBarDelegate::Create(
       InfoBarService::FromWebContents(web_contents),
       Profile::FromBrowserContext(
           web_contents->GetBrowserContext())->GetPrefs(),
       (ShellIntegration::CanSetAsDefaultBrowser() ==
           ShellIntegration::SET_DEFAULT_INTERACTIVE));
 }
 
-void CheckDefaultBrowserCallback(chrome::HostDesktopType desktop_type) {
-  if (ShellIntegration::GetDefaultBrowser() == ShellIntegration::NOT_DEFAULT) {
+void CheckDefaultBrowserCallback(bool show_prompt,
+                                 chrome::HostDesktopType desktop_type) {
+  ShellIntegration::DefaultWebClientState state =
+      ShellIntegration::GetDefaultBrowser();
+  if (state == ShellIntegration::IS_DEFAULT) {
+    // Notify the user in the future if Chrome ceases to be the user's chosen
+    // default browser.
+    PrefService* prefs = ProfileManager::GetLastUsedProfile()->GetPrefs();

[msw, 2015/06/16 19:23:01]

It seems odd to change the last used profile, maybe use |profile| from
ShowDefaultBrowserPrompt? (and avoid the profile_manager.h include)

[grt (UTC plus 2), 2015/06/16 19:31:53]

Ah, what I've done here may be unsafe for several reasons since this function is
run on the FILE thread, so it probably shouldn't touch the Profile* or its
prefs. Is it safe for CheckDefaultBrowserCallback to take the Profile* from
ShowDefaultBrowserPrompt and bounce it back to the UI thread to update the pref?
Could the Profile* have gone away during the bounce to/from the FILE thread?
This is why I involved the ProfileManager: in the normal case it will be the
same Profile*. If not, it will at least be some sensible Profile*.

[msw, 2015/06/16 20:29:49]

Maybe use profile->GetPath(), like ProfileSizeTask and NukeProfileFromDisk?

[grt (UTC plus 2), 2015/06/16 21:04:09]

Done.

+    prefs->SetBoolean(prefs::kCheckDefaultBrowser, true);
+  } else if (show_prompt && state == ShellIntegration::NOT_DEFAULT) {
     ShellIntegration::DefaultWebClientSetPermission default_change_mode =
         ShellIntegration::CanSetAsDefaultBrowser();
 
     if (default_change_mode != ShellIntegration::SET_DEFAULT_NOT_ALLOWED) {
       content::BrowserThread::PostTask(
           content::BrowserThread::UI, FROM_HERE,
           base::Bind(&NotifyNotDefaultBrowserCallback, desktop_type));
     }
   }
 }
 
 }  // namespace
 
 namespace chrome {
 
 void RegisterDefaultBrowserPromptPrefs(PrefRegistrySimple* registry) {
   registry->RegisterStringPref(
       prefs::kBrowserSuppressDefaultBrowserPrompt, std::string());
 }
 
 void ShowDefaultBrowserPrompt(Profile* profile, HostDesktopType desktop_type) {
   // We do not check if we are the default browser if:
+  // - There is a policy in control of this setting.
+  // We check if we are the default browser but do not prompt if:
   // - The user said "don't ask me again" on the infobar earlier.
-  // - There is a policy in control of this setting.
   // - The "suppress_default_browser_prompt_for_version" master preference is
   //     set to the current version.
-  if (!profile->GetPrefs()->GetBoolean(prefs::kCheckDefaultBrowser))
-    return;
+  bool show_prompt =
+      profile->GetPrefs()->GetBoolean(prefs::kCheckDefaultBrowser);
 
   if (g_browser_process->local_state()->IsManagedPreference(
       prefs::kDefaultBrowserSettingEnabled)) {
     if (g_browser_process->local_state()->GetBoolean(
         prefs::kDefaultBrowserSettingEnabled)) {
       content::BrowserThread::PostTask(
           content::BrowserThread::FILE, FROM_HERE,
           base::Bind(
               base::IgnoreResult(&ShellIntegration::SetAsDefaultBrowser)));
     } else {
       // TODO(pastarmovj): We can't really do anything meaningful here yet but
       // just prevent showing the infobar.
     }
     return;
   }
 
   const std::string disable_version_string =

[msw, 2015/06/16 19:23:01]

nit: maybe avoid this whole check if show_prompt is already false?

[grt (UTC plus 2), 2015/06/16 19:31:53]

Done.

       g_browser_process->local_state()->GetString(
           prefs::kBrowserSuppressDefaultBrowserPrompt);
   const Version disable_version(disable_version_string);
   DCHECK(disable_version_string.empty() || disable_version.IsValid());
   if (disable_version.IsValid()) {
     const chrome::VersionInfo version_info;
     if (disable_version.Equals(Version(version_info.Version())))
-      return;
+      show_prompt = false;

[msw, 2015/06/16 19:23:01]

nit: show_prompt &= disable_version.Equals(Version(version_info.Version()));

[grt (UTC plus 2), 2015/06/16 19:31:53]

I don't like that pattern since it's using a bitwise-AND on bools. It's a bit
subtle (it works because of bool->int->bool conversions).

   }
 
   content::BrowserThread::PostTask(
       content::BrowserThread::FILE, FROM_HERE,
-      base::Bind(&CheckDefaultBrowserCallback, desktop_type));
+      base::Bind(&CheckDefaultBrowserCallback, show_prompt, desktop_type));
 }
 
 #if !defined(OS_WIN)
 bool ShowFirstRunDefaultBrowserPrompt(Profile* profile) {
   return false;
 }
 #endif
 
 }  // namespace chrome