Componentize visitedlinks to src/components/visitedlink

components/visitedlink/visitedlink.gypi

Index: components/visitedlink/visitedlink.gypi
diff --git a/components/visitedlink/visitedlink.gypi b/components/visitedlink/visitedlink.gypi
new file mode 100644
index 0000000000000000000000000000000000000000..6db56a9e363114f4b395b991d709a8a09913c60b
--- /dev/null
+++ b/components/visitedlink/visitedlink.gypi
@@ -0,0 +1,66 @@
+# Copyright (c) 2013 The Chromium Authors. All rights reserved.
+# Use of this source code is governed by a BSD-style license that can be
+# found in the LICENSE file.
+
+{
+  'targets': [

[Jói, 2013/01/09 00:51:44]

It would be nice if there was a 'visitedlink' target that in the components
build would be a DLL.  Can do in a follow-up change, since it means establishing
the right exports etc.

[boliu, 2013/01/09 01:16:40]

I don't entirely know what this means. I've heard of components build and that
recent thread on windows pdb size, but I've never tried to use it, or ever
compiled on windows.

My guess is this is just a case of copy paste gyp configuration? Do you have an
example of this somewhere?

[Jói, 2013/01/09 18:42:42]

You use '<(component)' as the type of the target; this makes it a lib in the
normal build, and a DLL in the component build.  See e.g. base/base.gyp and
search for 'base_prefs'.

In that case I think 'visitedlink_common' would remain a lib, linked into both
'visitedlink_browser' and 'visitedlink_renderer' which could each be a
'<(component)'.

Once a target is sometimes built as a DLL, you need to add export macros to
export the relevant bits out of the DLL.  To see this in action in the Prefs
target, search for BASE_PREFS_EXPORT.

+    {
+      'target_name': 'visitedlink_common',
+      'type': 'static_library',
+      'include_dirs': [
+          '..',
+        ],
+      'dependencies': [
+        '../base/base.gyp:base',
+        '../content/content.gyp:content_common',
+        '../build/temp_gyp/googleurl.gyp:googleurl',
+        '../ipc/ipc.gyp:ipc',
+      ],
+      'sources': [
+        'common/render_messages.h',
+        'common/visitedlink_common.cc',
+        'common/visitedlink_common.h',
+        'common/visitedlink_message_generator.cc',
+        'common/visitedlink_message_generator.h',
+      ],
+    },
+    {
+      'target_name': 'visitedlink_browser',
+      'type': 'static_library',
+      'include_dirs': [
+          '..',
+        ],
+      'dependencies': [
+        'visitedlink_common',
+        '../base/base.gyp:base',
+        '../content/content.gyp:content_browser',
+        '../content/content.gyp:content_common',
+      ],
+      'sources': [
+        'browser/visitedlink_delegate.h',
+        'browser/visitedlink_event_listener.cc',
+        'browser/visitedlink_event_listener.h',
+        'browser/visitedlink_master.cc',
+        'browser/visitedlink_master.h',
+      ],
+    },
+    {
+      'target_name': 'visitedlink_renderer',
+      'type': 'static_library',
+      'include_dirs': [
+          '..',
+        ],
+      'dependencies': [
+        'visitedlink_common',
+        '../base/base.gyp:base',
+        '../content/content.gyp:content_common',
+        '../content/content.gyp:content_renderer',
+        '../third_party/WebKit/Source/WebKit/chromium/WebKit.gyp:webkit',
+      ],
+      'sources': [
+        'renderer/visitedlink_slave.cc',
+        'renderer/visitedlink_slave.h',
+      ],
+    },
+  ],
+}