Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1256)

Unified Diff: pkg/http/test/multipart_test.dart

Issue 11825010: Update pkg/http to use the new async APIs. (Closed) Base URL: https://dart.googlecode.com/svn/branches/bleeding_edge/dart
Patch Set: Code review changes Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « pkg/http/test/mock_client_test.dart ('k') | pkg/http/test/request_test.dart » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pkg/http/test/multipart_test.dart
diff --git a/pkg/http/test/multipart_test.dart b/pkg/http/test/multipart_test.dart
index 0e66bf3cbcda1ad28db35d7c2d673025505538f3..ab6d25a280433fbc155b180a4f3a50f8b69d9e9a 100644
--- a/pkg/http/test/multipart_test.dart
+++ b/pkg/http/test/multipart_test.dart
@@ -4,6 +4,7 @@
library multipart_test;
+import 'dart:async';
import 'dart:io';
import 'dart:utf';
@@ -29,7 +30,7 @@ class _BodyMatches extends BaseMatcher {
bool matches(item, MatchState matchState) {
if (item is! http.MultipartRequest) return false;
- var future = consumeInputStream(item.finalize()).then((bodyBytes) {
+ var future = item.finalize().toBytes().then((bodyBytes) {
var body = decodeUtf8(bodyBytes);
var contentType = new ContentType.fromString(
item.headers['content-type']);
@@ -155,7 +156,7 @@ void main() {
test('with a stream file', () {
var request = new http.MultipartRequest('POST', dummyUrl);
- var stream = new ListInputStream();
+ var stream = new StreamController.singleSubscription();
request.files.add(new http.MultipartFile('file', stream, 5));
expect(request, bodyMatches('''
@@ -167,14 +168,13 @@ void main() {
--{{boundary}}--
'''));
- stream.write([104, 101, 108, 108, 111]);
- stream.markEndOfStream();
+ stream.add([104, 101, 108, 108, 111]);
+ stream.close();
});
test('with an empty stream file', () {
var request = new http.MultipartRequest('POST', dummyUrl);
- var stream = new ListInputStream();
- stream.markEndOfStream();
+ var stream = new StreamController.singleSubscription();
request.files.add(new http.MultipartFile('file', stream, 0));
expect(request, bodyMatches('''
@@ -185,6 +185,8 @@ void main() {
--{{boundary}}--
'''));
+
+ stream.close();
});
test('with a byte file', () {
« no previous file with comments | « pkg/http/test/mock_client_test.dart ('k') | pkg/http/test/request_test.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698