Update pkg/http to use the new async APIs.

pkg/http/test/http_test.dart

Index: pkg/http/test/http_test.dart
diff --git a/pkg/http/test/http_test.dart b/pkg/http/test/http_test.dart
index 184566cc9ac9acdc1d97bf8140c4d39d874254da..48eada06ef163a70c6581bae5a3b38427f9fbc9f 100644
--- a/pkg/http/test/http_test.dart
+++ b/pkg/http/test/http_test.dart
@@ -16,17 +16,17 @@ main() {
     tearDown(stopServer);
 
     test('head', () {
-      http.head(serverUrl).then(expectAsync1((response) {
+      expect(http.head(serverUrl).then((response) {
         expect(response.statusCode, equals(200));
         expect(response.body, equals(''));
-      }));
+      }), completes);
     });
 
     test('get', () {
       expect(http.get(serverUrl, headers: {
         'X-Random-Header': 'Value',
         'X-Other-Header': 'Other Value'
-      }).then(expectAsync1((response) {
+      }).then((response) {

[Bob Nystrom, 2013/01/08 23:50:49]

I think you'll need guardAsync here and below, right?

[nweiz, 2013/01/09 00:52:11]

No, expect/completes handles all of that for us.

         expect(response.statusCode, equals(200));
         expect(response.body, parse(equals({
           'method': 'GET',
@@ -37,7 +37,7 @@ main() {
             'x-other-header': ['Other Value']
           },
         })));
-      })), completes);
+      }), completes);
     });
 
     test('post', () {
@@ -47,7 +47,7 @@ main() {
       }, fields: {
         'some-field': 'value',
         'other-field': 'other value'
-      }).then(expectAsync1((response) {
+      }).then((response) {
         expect(response.statusCode, equals(200));
         expect(response.body, parse(equals({
           'method': 'POST',
@@ -62,7 +62,7 @@ main() {
           },
           'body': 'some-field=value&other-field=other+value'
         })));
-      })), completes);
+      }), completes);
     });
 
     test('post without fields', () {
@@ -70,7 +70,7 @@ main() {
         'X-Random-Header': 'Value',
         'X-Other-Header': 'Other Value',
         'Content-Type': 'text/plain'
-      }).then(expectAsync1((response) {
+      }).then((response) {
         expect(response.statusCode, equals(200));
         expect(response.body, parse(equals({
           'method': 'POST',
@@ -82,7 +82,7 @@ main() {
             'x-other-header': ['Other Value']
           }
         })));
-      })), completes);
+      }), completes);
     });
 
     test('put', () {
@@ -92,7 +92,7 @@ main() {
       }, fields: {
         'some-field': 'value',
         'other-field': 'other value'
-      }).then(expectAsync1((response) {
+      }).then((response) {
         expect(response.statusCode, equals(200));
         expect(response.body, parse(equals({
           'method': 'PUT',
@@ -107,7 +107,7 @@ main() {
           },
           'body': 'some-field=value&other-field=other+value'
         })));
-      })), completes);
+      }), completes);
     });
 
     test('put without fields', () {
@@ -115,7 +115,7 @@ main() {
         'X-Random-Header': 'Value',
         'X-Other-Header': 'Other Value',
         'Content-Type': 'text/plain'
-      }).then(expectAsync1((response) {
+      }).then((response) {
         expect(response.statusCode, equals(200));
         expect(response.body, parse(equals({
           'method': 'PUT',
@@ -127,14 +127,14 @@ main() {
             'x-other-header': ['Other Value']
           }
         })));
-      })), completes);
+      }), completes);
     });
 
     test('delete', () {
       expect(http.delete(serverUrl, headers: {
         'X-Random-Header': 'Value',
         'X-Other-Header': 'Other Value'
-      }).then(expectAsync1((response) {
+      }).then((response) {
         expect(response.statusCode, equals(200));
         expect(response.body, parse(equals({
           'method': 'DELETE',
@@ -145,14 +145,14 @@ main() {
             'x-other-header': ['Other Value']
           }
         })));
-      })), completes);
+      }), completes);
     });
 
     test('read', () {
       expect(http.read(serverUrl, headers: {
         'X-Random-Header': 'Value',
         'X-Other-Header': 'Other Value'
-      }).then(expectAsync1((val) => val)), completion(parse(equals({
+      }).then((val) => val), completion(parse(equals({
         'method': 'GET',
         'path': '/',
         'headers': {
@@ -164,16 +164,14 @@ main() {
     });
 
     test('read throws an error for a 4** status code', () {
-      http.read(serverUrl.resolve('/error'))
-          .then((_) { throw "Error expected for readBytes"; })
-          .catchError(expectAsync1((e) { }), test: (e) => e is HttpException);
+      expect(http.read(serverUrl.resolve('/error')), throwsHttpException);
     });
 
     test('readBytes', () {
       var future = http.readBytes(serverUrl, headers: {
         'X-Random-Header': 'Value',
         'X-Other-Header': 'Other Value'
-      }).then(expectAsync1((bytes) => new String.fromCharCodes(bytes)));
+      }).then((bytes) => new String.fromCharCodes(bytes));
 
       expect(future, completion(parse(equals({
         'method': 'GET',
@@ -187,9 +185,7 @@ main() {
     });
 
     test('readBytes throws an error for a 4** status code', () {
-        http.readBytes(serverUrl.resolve('/error'))
-            .then((_) { throw "Error expected for readBytes"; })
-            .catchError(expectAsync1((e) { }), test: (e) => e is HttpException);
+      expect(http.readBytes(serverUrl.resolve('/error')), throwsHttpException);
     });
   });
 }