Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(62)

Issue 11825005: Move alternate_nav_infobar_delegate.* from c/b/infobars/ to c/b/ui/omnibox. (Closed)

Created:
7 years, 11 months ago by tfarina
Modified:
7 years, 11 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

Move alternate_nav_infobar_delegate.* from c/b/infobars/ to c/b/ui/omnibox. Also move the alternate_nav_url_fetcher.* files from c/b/ to c/b/ui/omnibox. BUG=164772 R=pkasting@chromium.org TBR=darin@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177793

Patch Set 1 #

Patch Set 2 : move to c/b/ui/location_bar #

Patch Set 3 : mv it to c/b/ui/omnibox #

Patch Set 4 : update chrome_browser_ui.gypi as well #

Unified diffs Side-by-side diffs Delta from patch set Stats (+20 lines, -374 lines) Patch
D chrome/browser/alternate_nav_url_fetcher.h View 1 1 chunk +0 lines, -92 lines 0 comments Download
M chrome/browser/alternate_nav_url_fetcher.cc View 1 1 chunk +0 lines, -152 lines 0 comments Download
D chrome/browser/infobars/alternate_nav_infobar_delegate.h View 1 chunk +0 lines, -39 lines 0 comments Download
D chrome/browser/infobars/alternate_nav_infobar_delegate.cc View 1 chunk +0 lines, -71 lines 0 comments Download
M chrome/browser/ui/cocoa/infobars/alternate_nav_infobar_controller.mm View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/cocoa/location_bar/location_bar_view_mac.mm View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/infobars/alternate_nav_infobar_gtk.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/gtk/location_bar_view_gtk.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
A + chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.h View 1 2 2 chunks +3 lines, -3 lines 0 comments Download
A + chrome/browser/ui/omnibox/alternate_nav_infobar_delegate.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
A + chrome/browser/ui/omnibox/alternate_nav_url_fetcher.h View 1 2 2 chunks +4 lines, -4 lines 0 comments Download
A + chrome/browser/ui/omnibox/alternate_nav_url_fetcher.cc View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/infobars/alternate_nav_infobar_view.cc View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/location_bar/location_bar_view.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M chrome/chrome_browser.gypi View 1 2 chunks +0 lines, -4 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (0 generated)
tfarina
7 years, 11 months ago (2013-01-08 21:49:44 UTC) #1
Peter Kasting
While living alongside the other files is good, adding things to chrome/browser/ is bad. I'd ...
7 years, 11 months ago (2013-01-17 23:14:45 UTC) #2
tfarina
On 2013/01/17 23:14:45, Peter Kasting wrote: > While living alongside the other files is good, ...
7 years, 11 months ago (2013-01-18 00:12:44 UTC) #3
Peter Kasting
On 2013/01/18 00:12:44, tfarina wrote: > Done. Moved to c/b/ui/location_bar/. PTAL. What about chrome/browser/ui/omnibox/? That's ...
7 years, 11 months ago (2013-01-18 00:18:41 UTC) #4
tfarina
On 2013/01/18 00:18:41, Peter Kasting wrote: > On 2013/01/18 00:12:44, tfarina wrote: > > Done. ...
7 years, 11 months ago (2013-01-18 00:50:27 UTC) #5
Peter Kasting
On 2013/01/18 00:50:27, tfarina wrote: > Your call. ;) In the interests of not moving ...
7 years, 11 months ago (2013-01-18 05:24:44 UTC) #6
tfarina
Done. PTAL.
7 years, 11 months ago (2013-01-18 11:33:00 UTC) #7
Peter Kasting
Rubber-stamp LGTM
7 years, 11 months ago (2013-01-18 18:10:34 UTC) #8
Peter Kasting
Oh, also please update change title/description
7 years, 11 months ago (2013-01-18 18:20:03 UTC) #9
tfarina
Done. CL title/description updated.
7 years, 11 months ago (2013-01-18 18:39:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/tfarina@chromium.org/11825005/10002
7 years, 11 months ago (2013-01-18 21:15:35 UTC) #11
commit-bot: I haz the power
7 years, 11 months ago (2013-01-18 23:22:23 UTC) #12
Message was sent while issue was closed.
Change committed as 177793

Powered by Google App Engine
This is Rietveld 408576698