Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(677)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1182493015: pathops coincident fixes (Closed)

Created:
5 years, 6 months ago by caryclark
Modified:
5 years, 5 months ago
Reviewers:
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

When three or more edges are coincident, the logic needs to compute the overlapping ranges and combine the winding into a single destination. This computes coincidence more rigorously, fixing the edge cases exposed by this bug. Also, add the ability to debug and dump pathop structures from the coincident context. TBR=reed@google.com BUG=skia:3651 Committed: https://skia.googlesource.com/skia/+/27c8eb8ffd7e221693d840c2b9279d53fe6f03d4

Patch Set 1 #

Patch Set 2 : revert gm test changes #

Patch Set 3 : work in progress (non compiling) #

Patch Set 4 : work in progress #

Patch Set 5 : work in progress #

Patch Set 6 : portable work in progress #

Patch Set 7 : non-extended debug tests pass #

Patch Set 8 : fix release build #

Patch Set 9 : move debug routine to main body #

Patch Set 10 : document fail in coincidence add missing #

Patch Set 11 : all tests (including extended) work #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1008 lines, -182 lines) Patch
M src/pathops/SkOpCoincidence.h View 1 2 3 4 5 6 7 8 9 10 2 chunks +50 lines, -4 lines 0 comments Download
M src/pathops/SkOpCoincidence.cpp View 1 2 3 4 5 6 7 8 9 10 9 chunks +254 lines, -23 lines 0 comments Download
M src/pathops/SkOpContour.h View 1 2 3 2 chunks +19 lines, -4 lines 0 comments Download
M src/pathops/SkOpSegment.h View 1 2 3 4 5 6 7 8 9 10 4 chunks +12 lines, -1 line 0 comments Download
M src/pathops/SkOpSegment.cpp View 1 2 3 4 5 6 7 8 9 10 8 chunks +121 lines, -33 lines 0 comments Download
M src/pathops/SkOpSpan.h View 1 2 3 4 5 6 chunks +29 lines, -0 lines 0 comments Download
M src/pathops/SkOpSpan.cpp View 1 2 3 4 5 1 chunk +54 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsCommon.cpp View 1 2 3 4 3 chunks +35 lines, -7 lines 0 comments Download
M src/pathops/SkPathOpsDebug.h View 1 2 3 4 5 2 chunks +12 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsDebug.cpp View 1 2 3 4 5 6 7 8 1 chunk +12 lines, -0 lines 0 comments Download
M src/pathops/SkPathOpsRect.h View 1 2 3 4 5 1 chunk +0 lines, -3 lines 0 comments Download
M src/pathops/SkPathOpsTypes.h View 1 2 3 4 5 6 2 chunks +2 lines, -13 lines 0 comments Download
M src/pathops/SkPathOpsTypes.cpp View 1 2 3 4 5 2 chunks +19 lines, -0 lines 0 comments Download
M src/ports/SkDebug_win.cpp View 1 2 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsBattles.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsDebug.cpp View 1 2 3 4 5 6 7 8 3 chunks +31 lines, -0 lines 0 comments Download
M tests/PathOpsIssue3651.cpp View 1 2 3 4 5 4 chunks +113 lines, -4 lines 0 comments Download
M tests/PathOpsSimplifyQuadThreadedTest.cpp View 1 2 3 4 5 6 7 8 9 1 chunk +1 line, -1 line 0 comments Download
M tests/PathOpsSimplifyTest.cpp View 1 2 3 4 5 6 7 8 9 10 1 chunk +14 lines, -0 lines 0 comments Download
M tools/pathops_sorter.htm View 1 2 3 4 5 1 chunk +40 lines, -3 lines 0 comments Download
M tools/pathops_visualizer.htm View 1 2 3 4 5 6 7 8 9 1 chunk +188 lines, -84 lines 0 comments Download

Messages

Total messages: 16 (8 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182493015/120001
5 years, 5 months ago (2015-07-01 18:28:28 UTC) #2
commit-bot: I haz the power
Dry run: Exceeded global retry quota
5 years, 5 months ago (2015-07-01 18:29:24 UTC) #4
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182493015/140001
5 years, 5 months ago (2015-07-01 18:45:19 UTC) #6
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot on client.skia (JOB_FAILED, http://build.chromium.org/p/client.skia/builders/Test-Ubuntu-GCC-GCE-CPU-AVX2-x86_64-Debug-Trybot/builds/1632) Build-Ubuntu-Clang-x86_64-Debug-Trybot on ...
5 years, 5 months ago (2015-07-01 18:46:51 UTC) #8
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182493015/90017
5 years, 5 months ago (2015-07-01 19:09:04 UTC) #11
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 5 months ago (2015-07-01 19:16:34 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182493015/190001
5 years, 5 months ago (2015-07-06 18:21:24 UTC) #15
commit-bot: I haz the power
5 years, 5 months ago (2015-07-06 18:38:38 UTC) #16
Message was sent while issue was closed. 
Committed patchset #11 (id:190001) as
https://skia.googlesource.com/skia/+/27c8eb8ffd7e221693d840c2b9279d53fe6f03d4

Powered by Google App Engine
This is Rietveld 408576698