chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc - Issue 1182493009: Wrench menu reorg phase 2

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc

Issue 1182493009: Wrench menu reorg phase 2 (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix incorrect title case expr causing wrong strings to be displayed on OSX Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc

diff --git a/chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc b/chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc

index ad58edd7a058a5f80ac064b6df8f169898c2d61b..49409e1edbabb159b96a3430dff455df54107f45 100644

--- a/chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc

+++ b/chrome/browser/ui/toolbar/wrench_menu_model_unittest.cc

@@ -154,8 +154,9 @@ TEST_F(WrenchMenuModelTest, Basics) {

int bookmarksModelIndex = -1;

for (int i = 0; i < itemCount; ++i) {

if (model.GetTypeAt(i) == ui::MenuModel::TYPE_SUBMENU) {

- // Tabs is the first submenu item. Bookmarks submenu is under tabs.

- bookmarksModelIndex = i + 1;

+ // Tabs is the first submenu item followed by downloads then the

+ // Bookmarks submenu.

Peter Kasting 2015/06/17 22:59:43 Nit: "The bookmarks submenu comes after the Tabs a

edwardjung 2015/06/18 16:52:05 Done.

+ bookmarksModelIndex = i + 2;

break;

}