Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(213)

Issue 1182493007: Revert of MIPS64: Enable shorten-64-to-32 warning. (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of MIPS64: Enable shorten-64-to-32 warning. (patchset #12 id:240001 of https://codereview.chromium.org/1133163005/) Reason for revert: Compile failure: https://chromegw.corp.google.com/i/client.v8/builders/V8%20Mac64%20-%20debug/builds/3070/steps/compile/logs/stdio Original issue's description: > MIPS64: Enable shorten-64-to-32 warning. > > Port cdc43bc5fd02fff2905e2e28a79054d0d1eee3ea > > Original commit message: > Enable clang's shorten-64-to-32 warning flag on ARM64, and fix the warnings > that arise. > > BUG= > > Committed: https://crrev.com/9af578a7c83b58a0ce25345998d9287cbf2030cb > Cr-Commit-Position: refs/heads/master@{#28990} TBR=danno@chromium.org,martyn.capewell@arm.com,paul.lind@imgtec.com,akos.palfi@imgtec.com,dusan.milosavljevic@imgtec.com,jkummerow@chromium.org,machenbach@chromium.org,svenpanne@chromium.org,balazs.kilvady@imgtec.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/74534bb8be0befff32cb372043a8c4c180ad7160 Cr-Commit-Position: refs/heads/master@{#28991}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+213 lines, -242 lines) Patch
M build/standalone.gypi View 2 chunks +1 line, -8 lines 0 comments Download
M src/base/platform/time.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/compiler/mips64/code-generator-mips64.cc View 9 chunks +18 lines, -25 lines 0 comments Download
M src/compiler/mips64/instruction-selector-mips64.cc View 4 chunks +7 lines, -7 lines 0 comments Download
M src/ic/mips64/stub-cache-mips64.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M src/mips64/assembler-mips64.h View 2 chunks +3 lines, -5 lines 0 comments Download
M src/mips64/assembler-mips64.cc View 6 chunks +8 lines, -11 lines 0 comments Download
M src/mips64/disasm-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.h View 1 chunk +1 line, -1 line 0 comments Download
M src/mips64/lithium-codegen-mips64.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/mips64/macro-assembler-mips64.cc View 22 chunks +29 lines, -33 lines 0 comments Download
M src/mips64/simulator-mips64.h View 3 chunks +46 lines, -46 lines 0 comments Download
M src/mips64/simulator-mips64.cc View 29 chunks +89 lines, -90 lines 0 comments Download
M test/cctest/test-assembler-mips64.cc View 2 chunks +4 lines, -6 lines 0 comments Download
M test/cctest/test-code-stubs-mips64.cc View 1 chunk +1 line, -2 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Yang
Created Revert of MIPS64: Enable shorten-64-to-32 warning.
5 years, 6 months ago (2015-06-12 09:58:02 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182493007/1
5 years, 6 months ago (2015-06-12 09:58:15 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-12 09:58:27 UTC) #3
commit-bot: I haz the power
5 years, 6 months ago (2015-06-12 09:58:44 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/74534bb8be0befff32cb372043a8c4c180ad7160
Cr-Commit-Position: refs/heads/master@{#28991}

Powered by Google App Engine
This is Rietveld 408576698