Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(807)

Unified Diff: Source/core/inspector/InspectorCSSAgent.cpp

Issue 1182483004: DevTools: [CSS] getMatchedStylesForNode should return styles inherited through shadow boundary (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: rebaseline Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « LayoutTests/inspector-protocol/css/css-shadow-host-rule-expected.txt ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/InspectorCSSAgent.cpp
diff --git a/Source/core/inspector/InspectorCSSAgent.cpp b/Source/core/inspector/InspectorCSSAgent.cpp
index 49d2abbf667634119a532fb1f7ca5ac81fdcc40c..46ad434f23c3c9a0a480b6895ed7343b2ac16042 100644
--- a/Source/core/inspector/InspectorCSSAgent.cpp
+++ b/Source/core/inspector/InspectorCSSAgent.cpp
@@ -774,7 +774,7 @@ void InspectorCSSAgent::getMatchedStylesForNode(ErrorString* errorString, int no
// Inherited styles.
if (!elementPseudoId && !asBool(excludeInherited)) {
RefPtr<TypeBuilder::Array<TypeBuilder::CSS::InheritedStyleEntry> > entries = TypeBuilder::Array<TypeBuilder::CSS::InheritedStyleEntry>::create();
- Element* parentElement = element->parentElement();
+ Element* parentElement = element->parentOrShadowHostElement();
while (parentElement) {
StyleResolver& parentStyleResolver = parentElement->ownerDocument()->ensureStyleResolver();
RefPtrWillBeRawPtr<CSSRuleList> parentMatchedRules = parentStyleResolver.cssRulesForElement(parentElement, StyleResolver::AllCSSRules);
@@ -787,7 +787,7 @@ void InspectorCSSAgent::getMatchedStylesForNode(ErrorString* errorString, int no
}
entries->addItem(entry.release());
- parentElement = parentElement->parentElement();
+ parentElement = parentElement->parentOrShadowHostElement();
}
inheritedEntries = entries.release();
« no previous file with comments | « LayoutTests/inspector-protocol/css/css-shadow-host-rule-expected.txt ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698