Chromium Code Reviews
Help | Chromium Project | Gerrit Changes | Sign in
(14)

Issue 1182483004: DevTools: [CSS] getMatchedStylesForNode should return styles inherited through shadow boundary (Closed)

Created:
4 years, 10 months ago by lushnikov
Modified:
4 years, 10 months ago
Reviewers:
dgozman, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Target Ref:
refs/remotes/origin/master
Project:
blink
Visibility:
Public.

Description

DevTools: [CSS] getMatchedStylesForNode should return styles inherited through shadow boundary The spec declares (article 7 at http://www.w3.org/TR/2012/WD-shadow-dom-20120522/): "the styles of the shadow host are inherited by the children of the shadow root" This patch makes CSS.getMatchedStylesForNode comply with spec. BUG=500915 R=pfeldman, dgozman Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=197366

Patch Set 1 #

Patch Set 2 : correct testcase #

Patch Set 3 : rebaseline #

Messages

Total messages: 10 (4 generated)
lushnikov
ptal
4 years, 10 months ago (2015-06-17 22:37:10 UTC) #1
pfeldman
lgtm
4 years, 10 months ago (2015-06-18 06:46:30 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182483004/20001
4 years, 10 months ago (2015-06-18 10:25:05 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: linux_blink_rel on tryserver.blink (JOB_FAILED, http://build.chromium.org/p/tryserver.blink/builders/linux_blink_rel/builds/67295)
4 years, 10 months ago (2015-06-18 11:54:02 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182483004/40001
4 years, 10 months ago (2015-06-18 15:11:42 UTC) #9
commit-bot: I haz the power
4 years, 10 months ago (2015-06-18 16:33:24 UTC) #10
Message was sent while issue was closed.
Committed patchset #3 (id:40001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=197366

Powered by Google App Engine
This is Rietveld 408576698