Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1061)

Unified Diff: Source/modules/accessibility/AXLayoutObject.cpp

Issue 1182483002: Fixed crash by checking if m_layoutObject->node() is not nullptr before calling isContentRichlyEdit… (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/modules/accessibility/AXLayoutObject.cpp
diff --git a/Source/modules/accessibility/AXLayoutObject.cpp b/Source/modules/accessibility/AXLayoutObject.cpp
index f1ca2df749ea94bc696413dc07ae1ee75562d896..63b98a2f16d6dff009536f948c0fd6faf42f08b4 100644
--- a/Source/modules/accessibility/AXLayoutObject.cpp
+++ b/Source/modules/accessibility/AXLayoutObject.cpp
@@ -375,15 +375,12 @@ static bool isLinkable(const AXObject& object)
return object.isLink() || object.isImage() || object.layoutObject()->isText();
}
+// Requires layoutObject to be present because it relies on style
+// user-modify. Don't move this logic to AXNodeObject.
+// TODO(nektar): Implement support in AXNodeObject for aria-hidden and canvas.
bool AXLayoutObject::isRichlyEditable() const
{
- ASSERT(node());
- ASSERT(m_layoutObject);
-
- // Requires m_layoutObject to be present because it relies on style
- // user-modify. Don't move this logic to AXNodeObject.
- // TODO(nektar): Implement support in AXNodeObject for aria-hidden and canvas.
- if (node()->isContentRichlyEditable())
+ if (node() && node()->isContentRichlyEditable())
return true;
if (isWebArea()) {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698