Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(59)

Side by Side Diff: sky/sdk/lib/widgets/scaffold.dart

Issue 1182463006: Clean up how we remove nodes from the render tree, and make sure we reinsert them in the right plac… (Closed) Base URL: https://github.com/domokit/mojo.git@master
Patch Set: Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | sky/sdk/lib/widgets/widget.dart » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 import '../rendering/box.dart'; 5 import '../rendering/box.dart';
6 import '../rendering/object.dart'; 6 import '../rendering/object.dart';
7 import '../theme2/view_configuration.dart'; 7 import '../theme2/view_configuration.dart';
8 import 'widget.dart'; 8 import 'widget.dart';
9 9
10 enum ScaffoldSlots { 10 enum ScaffoldSlots {
(...skipping 167 matching lines...) Expand 10 before | Expand all | Expand 10 after
178 Widget _drawer; 178 Widget _drawer;
179 Widget _floatingActionButton; 179 Widget _floatingActionButton;
180 180
181 RenderScaffold get root => super.root; 181 RenderScaffold get root => super.root;
182 RenderScaffold createNode() => new RenderScaffold(); 182 RenderScaffold createNode() => new RenderScaffold();
183 183
184 void insert(RenderObjectWrapper child, ScaffoldSlots slot) { 184 void insert(RenderObjectWrapper child, ScaffoldSlots slot) {
185 root[slot] = child != null ? child.root : null; 185 root[slot] = child != null ? child.root : null;
186 } 186 }
187 187
188 void removeChild(Widget node) { 188 void detachChildRoot(RenderObjectWrapper child) {
189 assert(node != null); 189 final root = this.root; // TODO(ianh): Remove this once the analyzer is clev erer
190 root.remove(node.root); 190 assert(root is RenderScaffold);
191 super.removeChild(node); 191 assert(root == child.root.parent);
192 root.remove(child.root);
193 assert(root == this.root); // TODO(ianh): Remove this once the analyzer is c leverer
192 } 194 }
193 195
194 void remove() { 196 void remove() {
195 if (_toolbar != null) 197 if (_toolbar != null)
196 removeChild(_toolbar); 198 removeChild(_toolbar);
197 if (_body != null) 199 if (_body != null)
198 removeChild(_body); 200 removeChild(_body);
199 if (_statusBar != null) 201 if (_statusBar != null)
200 removeChild(_statusBar); 202 removeChild(_statusBar);
201 if (_drawer != null) 203 if (_drawer != null)
202 removeChild(_drawer); 204 removeChild(_drawer);
203 if (_floatingActionButton != null) 205 if (_floatingActionButton != null)
204 removeChild(_floatingActionButton); 206 removeChild(_floatingActionButton);
205 super.remove(); 207 super.remove();
206 } 208 }
207 209
208 void syncRenderObject(Widget old) { 210 void syncRenderObject(Widget old) {
209 super.syncRenderObject(old); 211 super.syncRenderObject(old);
210 _toolbar = syncChild(_toolbar, old is Scaffold ? old._toolbar : null, Scaffo ldSlots.toolbar); 212 _toolbar = syncChild(_toolbar, old is Scaffold ? old._toolbar : null, Scaffo ldSlots.toolbar);
211 _body = syncChild(_body, old is Scaffold ? old._body : null, ScaffoldSlots.b ody); 213 _body = syncChild(_body, old is Scaffold ? old._body : null, ScaffoldSlots.b ody);
212 _statusBar = syncChild(_statusBar, old is Scaffold ? old._statusBar : null, ScaffoldSlots.statusBar); 214 _statusBar = syncChild(_statusBar, old is Scaffold ? old._statusBar : null, ScaffoldSlots.statusBar);
213 _drawer = syncChild(_drawer, old is Scaffold ? old._drawer : null, ScaffoldS lots.drawer); 215 _drawer = syncChild(_drawer, old is Scaffold ? old._drawer : null, ScaffoldS lots.drawer);
214 _floatingActionButton = syncChild(_floatingActionButton, old is Scaffold ? o ld._floatingActionButton : null, ScaffoldSlots.floatingActionButton); 216 _floatingActionButton = syncChild(_floatingActionButton, old is Scaffold ? o ld._floatingActionButton : null, ScaffoldSlots.floatingActionButton);
215 } 217 }
216 218
217 } 219 }
OLDNEW
« no previous file with comments | « no previous file | sky/sdk/lib/widgets/widget.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698