Issue 1182463006: Clean up how we remove nodes from the render tree, and make sure we reinsert them in the right plac…

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1182463006: Clean up how we remove nodes from the render tree, and make sure we reinsert them in the right plac… (Closed)

Created:
5 years, 6 months ago by Hixie

Modified:
5 years, 6 months ago

Reviewers:
abarth-chromium

CC:
abarth-chromium, gregsimon, jackson_old, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Clean up how we remove nodes from the render tree, and make sure we reinsert them in the right place. Fixes weird behaviours when the old and new children of TagNodes can't be synced. R=abarth@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/b9ee1ee14b51717b5d37e85a0d25521895ce0f69

Created: 5 years, 6 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+263 lines, -23 lines)			Patch
M	sky/sdk/lib/widgets/scaffold.dart	View	1 2	1 chunk	+6 lines, -4 lines	0 comments	Download
M	sky/sdk/lib/widgets/widget.dart	View	1 2	14 chunks	+49 lines, -19 lines	0 comments	Download
A	sky/tests/widgets/syncs1.dart	View	1	1 chunk	+100 lines, -0 lines	0 comments	Download
A	sky/tests/widgets/syncs1-expected.txt	View	1	1 chunk	+108 lines, -0 lines	0 comments	Download

Total messages: 4 (1 generated)

Hixie

5 years, 6 months ago (2015-06-17 20:56:14 UTC) #4

Message was sent while issue was closed.

Committed patchset #3 (id:40001) manually as
b9ee1ee14b51717b5d37e85a0d25521895ce0f69 (presubmit successful).