Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2148)

Unified Diff: content/common/navigation_params.h

Issue 1182453002: PlzNavigate: support for should_replace_current_entry (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Addressed Charlie's comments Created 5 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index b0b3d3f21eb10446380d4c3f20ce1bf750634dab..1862377868f85c2e92af217f4943068288e519d9 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -42,6 +42,7 @@ struct CONTENT_EXPORT CommonNavigationParams {
ui::PageTransition transition,
FrameMsg_Navigate_Type::Value navigation_type,
bool allow_download,
+ bool should_replace_current_entry,
base::TimeTicks ui_timestamp,
FrameMsg_UILoadMetricsReportType::Value report_type,
const GURL& base_url_for_data_url,
@@ -66,6 +67,13 @@ struct CONTENT_EXPORT CommonNavigationParams {
// Avoid downloading when in view-source mode.
bool allow_download;
+ // Informs the RenderView the pending navigation should replace the current
+ // history entry when it commits. This is used for cross-process redirects so
+ // the transferred navigation can recover the navigation state.
+ // PlzNavigate: this is used by client-side redirects to indicate that when
+ // the navigation commits, it should commit in the existing page.
+ bool should_replace_current_entry;
+
// Timestamp of the user input event that triggered this navigation. Empty if
// the navigation was not triggered by clicking on a link or by receiving an
// intent on Android.
@@ -134,7 +142,6 @@ struct CONTENT_EXPORT StartNavigationParams {
bool is_post,
const std::string& extra_headers,
const std::vector<unsigned char>& browser_initiated_post_data,
- bool should_replace_current_entry,
int transferred_request_child_id,
int transferred_request_request_id);
~StartNavigationParams();
@@ -149,11 +156,6 @@ struct CONTENT_EXPORT StartNavigationParams {
// otherwise.
std::vector<unsigned char> browser_initiated_post_data;
- // Informs the RenderView the pending navigation should replace the current
- // history entry when it commits. This is used for cross-process redirects so
- // the transferred navigation can recover the navigation state.
- bool should_replace_current_entry;
-
// The following two members identify a previous request that has been
// created before this navigation is being transferred to a new render view.
// This serves the purpose of recycling the old request.

Powered by Google App Engine
This is Rietveld 408576698