PlzNavigate: support for should_replace_current_entry

content/common/navigation_params.h

Index: content/common/navigation_params.h
diff --git a/content/common/navigation_params.h b/content/common/navigation_params.h
index 805947112128c488e913acfe684a6239da38e244..c81c5daad19b7d9c240b96e7fcdf1dee34daaebe 100644
--- a/content/common/navigation_params.h
+++ b/content/common/navigation_params.h
@@ -39,7 +39,8 @@ struct CONTENT_EXPORT CommonNavigationParams {
                          base::TimeTicks ui_timestamp,
                          FrameMsg_UILoadMetricsReportType::Value report_type,
                          const GURL& base_url_for_data_url,
-                         const GURL& history_url_for_data_url);
+                         const GURL& history_url_for_data_url,
+                         bool lock_history_list);
   ~CommonNavigationParams();
 
   // The URL to navigate to.
@@ -75,6 +76,11 @@ struct CONTENT_EXPORT CommonNavigationParams {
   // History URL for use in Blink's SubstituteData.
   // Is only used with data: URLs.
   GURL history_url_for_data_url;
+
+  // PlzNavigate
+  // Whether the navigation should generate a new entry in the history list on
+  // commit. This is false for many client-side redirects.
+  bool lock_history_list;

[Avi (use Gerrit), 2015/06/11 19:09:01]

The meaning of this is unclear.

The comment says "Whether the navigation should generate a new entry...." If the
variable were named "generate_new_entry" then it would be clear what the boolean
meant. But since the name is "lock_history_list", is it opposite? If we want a
new entry we set this to false?

Please clarify what true and false mean for this variable.

 };
 
 // Provided by the renderer ----------------------------------------------------