Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(400)

Issue 1182443002: Add extras test for calling into runtime. (Closed)

Created:
5 years, 6 months ago by Yang
Modified:
5 years, 6 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Add extras test for calling into runtime. The alternative of passing an object template at context creation is unfeasible because we need a context to instantiate the template. At the time we create the context from snapshot or bootstrap from scratch, we would already need that template instance, leading to a chicken-and-egg problem. This is an alternative that is simpler and less intrusive. R=domenic@chromium.org, jochen@chromium.org Committed: https://crrev.com/bd219a760185fe59723c89e23ef357106fad473e Cr-Commit-Position: refs/heads/master@{#28938}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+21 lines, -3 lines) Patch
M test/cctest/test-api.cc View 1 chunk +17 lines, -3 lines 0 comments Download
M test/cctest/test-extra.js View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 9 (1 generated)
Yang
5 years, 6 months ago (2015-06-11 11:42:04 UTC) #1
jochen (gone - plz use gerrit)
lgtm
5 years, 6 months ago (2015-06-11 11:42:54 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182443002/1
5 years, 6 months ago (2015-06-11 11:46:55 UTC) #4
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-11 12:19:45 UTC) #5
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/bd219a760185fe59723c89e23ef357106fad473e Cr-Commit-Position: refs/heads/master@{#28938}
5 years, 6 months ago (2015-06-11 12:20:00 UTC) #6
domenic
On 2015/06/11 at 11:42:04, yangguo wrote: > We may want to consider renaming "exports." I ...
5 years, 6 months ago (2015-06-11 17:59:58 UTC) #7
domenic
On 2015/06/11 at 17:59:58, domenic wrote: > On 2015/06/11 at 11:42:04, yangguo wrote: > > ...
5 years, 6 months ago (2015-06-11 18:08:05 UTC) #8
Yang
5 years, 6 months ago (2015-06-12 08:56:54 UTC) #9
Message was sent while issue was closed.
On 2015/06/11 18:08:05, domenic wrote:
> On 2015/06/11 at 17:59:58, domenic wrote:
> > On 2015/06/11 at 11:42:04, yangguo wrote:
> > > 
> > 
> > We may want to consider renaming "exports." I do not know what a good name
> would be though.
> > 
> > I will update the design doc with this new pattern.
> 
> Design doc updated.
>
https://docs.google.com/document/d/1AT5-T0aHGp7Lt29vPWFr2-qG8r3l9CByyvKwEuA8E...
> 
> Maybe we could consider introducing two separate objects, exports and imports,
> which are only differentiated by convention?

Or we could just rename it to "binding".

Powered by Google App Engine
This is Rietveld 408576698