tools/metrics/histograms/histograms.xml - Issue 1182423004: Adding UMA stat when generated password set for newly created PasswordFormManager.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.

Issue 1182423004: Adding UMA stat when generated password set for newly created PasswordFormManager. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressing nit. Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Download patch

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index e21ad20542c5da3cd945e9d873ff6730a6246adc..fd0095e8e1ac60475d7e0c3a202c728ae5c1eed9 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -27708,6 +27708,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

</summary>

</histogram>

+<histogram name="PasswordManager.GeneratedFormHasNoFormManager" enum="Boolean">

Ilya Sherman 2015/06/28 02:19:11 Please define and use a custom boolean here, with

Deepak 2015/06/29 04:01:49 Done.

+ <owner>gcasto@chromium.org</owner>

+ <owner>vabr@chromium.org</owner>

+ <owner>deepak.m1@samsung.com</owner>

+ <summary>

+ Indicates if the generation state of a password was changed but existing

+ form was not found.

Ilya Sherman 2015/06/28 02:19:11 nit: Suggested rephrasing (feel free to refine fur

Deepak 2015/06/29 04:01:49 Done.

+ </summary>

+</histogram>

<owner>dubroy@chromium.org</owner>

<owner>vabr@chromium.org</owner>

« no previous file with comments | « components/password_manager/core/browser/password_manager.cc ('k') | no next file » | no next file with comments »