Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(564)

Issue 1182413002: Fix nested about:blank iframes in --site-per-process. (Closed)

Created:
5 years, 6 months ago by Charlie Reis
Modified:
5 years, 6 months ago
Reviewers:
Avi (use Gerrit)
CC:
chromium-reviews, jam, nasko+codewatch_chromium.org, creis+watch_chromium.org, darin-cc_chromium.org, site-isolation-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Fix nested about:blank iframes in --site-per-process. Ignore commits if an ancestor has no last committed frame entry. BUG=236848 TEST=Nested about:blank iframes don't crash in --site-per-process. Committed: https://crrev.com/2e31fea854fbb0e026a54fc528c8a5fa96e71060 Cr-Commit-Position: refs/heads/master@{#334385}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M content/browser/frame_host/navigation_controller_impl_browsertest.cc View 1 chunk +13 lines, -0 lines 0 comments Download
M content/browser/frame_host/navigation_entry_impl.cc View 1 chunk +5 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Charlie Reis
Avi, can you take a look? This was caught by the ExtensionApiTest.ContentScriptAboutBlankIframes and ExtensionApiTest.ContentScriptAboutBlankAndSrcdoc tests ...
5 years, 6 months ago (2015-06-15 14:02:07 UTC) #2
Avi (use Gerrit)
lgtm
5 years, 6 months ago (2015-06-15 15:43:45 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182413002/1
5 years, 6 months ago (2015-06-15 16:00:14 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 6 months ago (2015-06-15 16:05:09 UTC) #6
commit-bot: I haz the power
5 years, 6 months ago (2015-06-15 16:07:05 UTC) #7
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2e31fea854fbb0e026a54fc528c8a5fa96e71060
Cr-Commit-Position: refs/heads/master@{#334385}

Powered by Google App Engine
This is Rietveld 408576698