Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(399)

Issue 11824051: Revert 175871 (Closed)

Created:
7 years, 11 months ago by acolwell GONE FROM CHROMIUM
Modified:
7 years, 11 months ago
CC:
chromium-reviews, oshima+watch_chromium.org, stevenjb+watch_chromium.org, nkostylev+watch_chromium.org, davemoore+watch_chromium.org
Visibility:
Public.

Description

Revert 175871 This change didn't end up being the source of the ChromeOS problems so I'm reverting my revert. > Revert 175826 > > This change appears to be breaking the ChromeOS(x86) and ChromeOS(amd64) bots. > http://build.chromium.org/p/chromium.chromiumos/builders/ChromiumOS%20%28x86%29/builds/11010 > > > Clean up: remove unnecessary if-branches on initialization of the a11y prefs. > > > > According to the comment at preferences.cc:96, some accessibility prefs may be already registered in WizardController::RegisterPrefs. But the magnifier prefs are never registered there, hence we can remove if statements. > > > > BUG=none > > TEST=launch ChromeOS, and login. > > > > Review URL: https://chromiumcodereview.appspot.com/11820018 > > TBR=yoshiki@chromium.org > Review URL: https://codereview.chromium.org/11817029 TBR=acolwell@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175937

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -18 lines) Patch
M chrome/browser/chromeos/preferences.cc View 2 chunks +11 lines, -18 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
acolwell GONE FROM CHROMIUM
7 years, 11 months ago (2013-01-10 00:09:41 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698