content/browser/web_contents/web_contents_impl.cc - Issue 11824050: InstantExtended: Committed NTP

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 11824050: InstantExtended: Committed NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use WebContentsDelegate for focusing omnibox by default. Created 7 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/web_contents/web_contents_impl.cc

diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc

index 2db6514b6d96651fa5b270f296a59b20c7cd7f5d..bddf226aa41510105cefc6b9583c1040b795928c 100644

--- a/content/browser/web_contents/web_contents_impl.cc

+++ b/content/browser/web_contents/web_contents_impl.cc

@@ -1987,7 +1987,11 @@ bool WebContentsImpl::FocusLocationBarByDefault() {

if (web_ui)

return web_ui->ShouldFocusLocationBarByDefault();

NavigationEntry* entry = controller_.GetActiveEntry();

- return (entry && entry->GetURL() == GURL(chrome::kAboutBlankURL));

+ if (entry && entry->GetURL() == GURL(chrome::kAboutBlankURL))

+ return true;

+ if (delegate_)

+ return delegate_->ShouldFocusLocationBarByDefault(this);

+ return false;

jam 2013/02/06 22:22:51 nit: return delegate_ && delegate_->Foo(); that ma

}

void WebContentsImpl::SetFocusToLocationBar(bool select_all) {