Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3486)

Unified Diff: chrome/browser/instant/instant_tab.h

Issue 11824050: InstantExtended: Committed NTP (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments. Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/instant/instant_tab.h
diff --git a/chrome/browser/instant/instant_tab.h b/chrome/browser/instant/instant_tab.h
index 2e0321abe3bb6926efaff9b8bb7b9ee9214bf960..00ce59df65b6dc3cc2a0cde9ed023b5f2cfd7c1f 100644
--- a/chrome/browser/instant/instant_tab.h
+++ b/chrome/browser/instant/instant_tab.h
@@ -5,66 +5,27 @@
#ifndef CHROME_BROWSER_INSTANT_INSTANT_TAB_H_
#define CHROME_BROWSER_INSTANT_INSTANT_TAB_H_
-#include <vector>
-
#include "base/basictypes.h"
#include "base/compiler_specific.h"
-#include "base/string16.h"
-#include "chrome/browser/instant/instant_client.h"
-
-struct InstantAutocompleteResult;
-class InstantController;
-
-namespace content {
-class WebContents;
-}
+#include "chrome/browser/instant/instant_page.h"
-// InstantTab is used to communicate with a committed search results page, i.e.,
-// an actual tab on the tab strip (compare: InstantLoader, which has a preview
-// page that appears and disappears as the user types in the omnibox).
-class InstantTab : public InstantClient::Delegate {
+// InstantTab represents a committed page (i.e. an actual tab on the tab strip)
+// that supports the Instant API.
+class InstantTab : public InstantPage {
public:
- // Doesn't take ownership of either |controller| or |contents|.
- InstantTab(InstantController* controller, content::WebContents* contents);
+ // Doesn't take ownership of either |delegate|.
+ explicit InstantTab(InstantPage::Delegate* delegate);
virtual ~InstantTab();
- content::WebContents* contents() const { return contents_; }
-
- // Start observing |contents_| for messages. Sends a message to determine if
+ // Start observing |contents| for messages. Sends a message to determine if
// the page supports the Instant API.
- void Init();
-
- // Calls through to methods of the same name on InstantClient.
- void Update(const string16& text,
- size_t selection_start,
- size_t selection_end,
- bool verbatim);
- void Submit(const string16& text);
- void SendAutocompleteResults(
- const std::vector<InstantAutocompleteResult>& results);
- void SetDisplayInstantResults(bool display_instant_results);
- void UpOrDownKeyPressed(int count);
- void SetMarginSize(int start, int end);
+ void Init(content::WebContents* contents);
private:
- // Overridden from InstantClient::Delegate:
- virtual void SetSuggestions(
- const std::vector<InstantSuggestion>& suggestions) OVERRIDE;
- virtual void InstantSupportDetermined(bool supports_instant) OVERRIDE;
- virtual void ShowInstantPreview(InstantShownReason reason,
- int height,
- InstantSizeUnits units) OVERRIDE;
- virtual void StartCapturingKeyStrokes() OVERRIDE;
- virtual void StopCapturingKeyStrokes() OVERRIDE;
- virtual void RenderViewGone() OVERRIDE;
- virtual void AboutToNavigateMainFrame(const GURL& url) OVERRIDE;
- virtual void NavigateToURL(const GURL& url,
- content::PageTransition transition) OVERRIDE;
-
- InstantClient client_;
- InstantController* const controller_;
- content::WebContents* const contents_;
- bool supports_instant_;
+ // Overridden from InstantPage:
+ virtual bool ShouldProcessRenderViewGone() const OVERRIDE;
+ virtual bool ShouldProcessAboutToNavigateMainFrame() const OVERRIDE;
+ virtual bool ShouldProcessShowInstantPreview() const OVERRIDE;
DISALLOW_COPY_AND_ASSIGN(InstantTab);
};

Powered by Google App Engine
This is Rietveld 408576698