Issue 11824046: Detect user initiated network connection failures.

Issue 11824046: Detect user initiated network connection failures. (Closed)

Created:
7 years, 11 months ago by stevenjb

Modified:
7 years, 11 months ago

Reviewers:
Greg Spencer (Chromium), gauravsh

CC:
chromium-reviews, nkostylev+watch_chromium.org, gspencer+watch_chromium.org, gauravsh+watch_chromium.org, oshima+watch_chromium.org, stevenjb+watch_chromium.org, davemoore+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Detect user initiated network connection failures. This also recognizes additional Shill authentication errors. BUG=168056 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176017

Patch Set 2 : Fix spelling #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+65 lines, -19 lines)			Patch
M	chrome/browser/chromeos/cros/native_network_parser.cc	View		1 chunk	+3 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_constants.h	View		2 chunks	+11 lines, -0 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.h	View		3 chunks	+8 lines, -3 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library.cc	View	1	4 chunks	+41 lines, -14 lines	0 comments	Download
M	chrome/browser/chromeos/cros/network_library_impl_base.cc	View		1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/chromeos/cros/network_library_impl_stub.cc	View		1 chunk	+1 line, -1 line	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

stevenjb

This CL does two things: 1. Recognizes additional error codes which, once Shill sets them ...

7 years, 11 months ago (2013-01-09 23:45:12 UTC) #1

Greg Spencer (Chromium)

LGTM. https://codereview.chromium.org/11824046/diff/1/chrome/browser/chromeos/cros/network_library.cc File chrome/browser/chromeos/cros/network_library.cc (right): https://codereview.chromium.org/11824046/diff/1/chrome/browser/chromeos/cros/network_library.cc#newcode1249 chrome/browser/chromeos/cros/network_library.cc:1249: // If the user initiated a conenction and ...

7 years, 11 months ago (2013-01-10 00:39:42 UTC) #2

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/stevenjb@chromium.org/11824046/5001

7 years, 11 months ago (2013-01-10 01:52:43 UTC) #3

Message was sent while issue was closed.

Change committed as 176017

Expand Messages | Collapse Messages