Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 11824033: ash: Update window shadow assets (Closed)

Created:
7 years, 11 months ago by James Cook
Modified:
7 years, 11 months ago
Reviewers:
oshima
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

ash: Update window shadow assets This version has a shorter bottom-edge shadow which makes the windows look better when they are at the bottom of the screen near the launcher. It also eliminates some subtle noise in the RGB channels. BUG=168300 TEST=manual, shadows look correct on normal and high resolution displays Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175855

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-32 lines, --32 lines) Patch
M ui/resources/default_100_percent/window_shadow_active_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_active_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_active_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_active_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_active_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_active_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_active_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_active_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_inactive_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_inactive_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_inactive_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_inactive_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_inactive_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_inactive_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_inactive_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_100_percent/window_shadow_inactive_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_active_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_active_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_active_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_active_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_active_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_active_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_active_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_active_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_inactive_bottom.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_inactive_bottom_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_inactive_bottom_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_inactive_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_inactive_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_inactive_top.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_inactive_top_left.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M ui/resources/default_200_percent/window_shadow_inactive_top_right.png View 0 chunks +-1 lines, --1 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
James Cook
Oshima, can you approve this? I can show you the assets in person if you ...
7 years, 11 months ago (2013-01-09 17:14:21 UTC) #1
oshima
7 years, 11 months ago (2013-01-09 19:02:55 UTC) #2
lgtm

Powered by Google App Engine
This is Rietveld 408576698