Issue 11824026: Unbreak memory_benchmark some more.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11824026: Unbreak memory_benchmark some more. (Closed)

Created:
7 years, 11 months ago by marja

Modified:
7 years, 11 months ago

Reviewers:
nduca

CC:
chromium-reviews, chrome-speed-team+watch_google.com, pam+watch_chromium.org, telemetry+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Unbreak memory_benchmark some more. (r175783 was not enough.) TBR=nduca BUG=NONE Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175794

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	tools/telemetry/telemetry/page_benchmark_results.py	View		2 chunks	+4 lines, -2 lines	0 comments	Download

Total messages: 2 (0 generated)

marja

Oops, here's another fix that is needed and I'll commit this with TBR, too. (I ...

7 years, 11 months ago (2013-01-09 13:48:27 UTC) #1

nduca

7 years, 11 months ago (2013-01-09 21:43:19 UTC) #2

Message was sent while issue was closed.

Can you please add a unittest to page_benchmark_results_unittest.py that checks
for the behvaior that this patch fixes?