Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(289)

Issue 11824020: google_apis: Implement DownloadFile in FakeDriveService (Closed)

Created:
7 years, 11 months ago by satorux1
Modified:
7 years, 11 months ago
Reviewers:
kinaba
CC:
chromium-reviews, achuith+watch_chromium.org
Visibility:
Public.

Description

google_apis: Implement DownloadFile in FakeDriveService BUG=162350 TEST=none; no changes in production code. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176031

Patch Set 1 #

Patch Set 2 : rebase #

Patch Set 3 : fix win build #

Patch Set 4 : add DownloadFile_NonexistingFile test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -0 lines) Patch
M chrome/browser/google_apis/fake_drive_service.cc View 2 chunks +24 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/fake_drive_service_unittest.cc View 1 2 3 2 chunks +52 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/test_util.h View 1 1 chunk +7 lines, -0 lines 0 comments Download
M chrome/browser/google_apis/test_util.cc View 1 1 chunk +9 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
satorux1
7 years, 11 months ago (2013-01-09 08:14:15 UTC) #1
kinaba
lgtm
7 years, 11 months ago (2013-01-10 00:02:11 UTC) #2
satorux1
Added DownloadFile_NonexistingFile. PTAL just in case.
7 years, 11 months ago (2013-01-10 04:19:51 UTC) #3
kinaba
7 years, 11 months ago (2013-01-10 04:31:02 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698