Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(217)

Unified Diff: tools/telemetry/telemetry/csv_page_benchmark_results.py

Issue 11824014: [Telemetry] Fix Csv validation (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/telemetry/telemetry/csv_page_benchmark_results.py
diff --git a/tools/telemetry/telemetry/csv_page_benchmark_results.py b/tools/telemetry/telemetry/csv_page_benchmark_results.py
index 3a9995e344b3278d8e596701270e0c461245f416..c520825c44fd817a790bab2c879278395747f7dd 100644
--- a/tools/telemetry/telemetry/csv_page_benchmark_results.py
+++ b/tools/telemetry/telemetry/csv_page_benchmark_results.py
@@ -37,8 +37,10 @@ class CsvPageBenchmarkResults(PageBenchmarkResults):
def _ValidateOutputNamesForCurrentPage(self):
assert self._did_output_header
current_page_measurement_names = \
- self.values_for_current_page.measurement_names
- if self._header_names_written_to_writer == current_page_measurement_names:
+ set(self.values_for_current_page.measurement_names)
+ header_names_written_to_writer = \
+ set(self._header_names_written_to_writer)
+ if header_names_written_to_writer == current_page_measurement_names:
return
assert False, """To use CsvPageBenchmarkResults, you must add the same
result names for every page. In this case, first page output:
@@ -50,7 +52,7 @@ output:
Change your test to produce the same thing each time, or modify
MultiPageBenchmark.results_are_the_same_on_every_page to return False.
-""" % (repr(self._header_names_written_to_writer),
+""" % (repr(header_names_written_to_writer),
repr(current_page_measurement_names))
def _OutputHeader(self):
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698