Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(344)

Issue 11824009: Use mac browser action overflow asset on all platforms (Closed)

Created:
7 years, 11 months ago by Nico
Modified:
7 years, 11 months ago
Reviewers:
Elliot Glaysher, sail
CC:
chromium-reviews, oshima+watch_chromium.org
Visibility:
Public.

Description

Use mac browser action overflow asset on all platforms Hot on the heels of r175591, we're now using the centered asset everywhere. This moves the mac asset over to common, removes the one in the root directory (which was used by gtk), and updates the grd file. BUG=168897 TEST=look at browser actions overflow asset, it's vertically centered. on all platforms. TBR=sail Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=175612

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+-18 lines, --8 lines) Patch
D chrome/app/theme/default_100_percent/browser_actions_overflow.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/browser_actions_overflow_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/browser_actions_overflow_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/browser_actions_overflow_win.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/browser_actions_overflow_win_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/browser_actions_overflow_win_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/browser_actions_overflow_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/browser_actions_overflow_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_100_percent/common/browser_actions_overflow_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/mac/browser_actions_overflow_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/mac/browser_actions_overflow_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_100_percent/mac/browser_actions_overflow_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/browser_actions_overflow.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/browser_actions_overflow_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/browser_actions_overflow_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_200_percent/common/browser_actions_overflow_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_200_percent/common/browser_actions_overflow_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/default_200_percent/common/browser_actions_overflow_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/mac/browser_actions_overflow_hover.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/mac/browser_actions_overflow_normal.png View 0 chunks +-1 lines, --1 lines 0 comments Download
D chrome/app/theme/default_200_percent/mac/browser_actions_overflow_pressed.png View 0 chunks +-1 lines, --1 lines 0 comments Download
M chrome/app/theme/theme_resources.grd View 1 chunk +3 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Nico
erg: This new asset is 2px wider than the old one, but c/b/ui/gtk/custom_button.cc looks like ...
7 years, 11 months ago (2013-01-08 23:47:56 UTC) #1
Elliot Glaysher
7 years, 11 months ago (2013-01-08 23:50:18 UTC) #2
On 2013/01/08 23:47:56, Nico wrote:
> erg: This new asset is 2px wider than the old one, but
> c/b/ui/gtk/custom_button.cc looks like it'll adapt to the new width
> automatically, so I guess this should be fine?

theoretically. as long as you aren't touching the height, this should be ok.
lgtm.

Powered by Google App Engine
This is Rietveld 408576698