Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1565)

Unified Diff: chrome/browser/extensions/api/messaging/message_service.cc

Issue 11824004: Do not pass URLs in onUpdated events to extensions unless they have the (Closed) Base URL: http://git.chromium.org/chromium/src.git@master
Patch Set: Revised to address review comments Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/extensions/api/messaging/message_service.cc
diff --git a/chrome/browser/extensions/api/messaging/message_service.cc b/chrome/browser/extensions/api/messaging/message_service.cc
index afc9407a64ebb14a26314acb76299963ec47f808..159daf5826e1c04c7f159c134884a1f9ca62824d 100644
--- a/chrome/browser/extensions/api/messaging/message_service.cc
+++ b/chrome/browser/extensions/api/messaging/message_service.cc
@@ -162,7 +162,7 @@ void MessageService::OpenChannelToExtension(
std::string tab_json = "null";
if (source_contents) {
scoped_ptr<DictionaryValue> tab_value(ExtensionTabUtil::CreateTabValue(
- source_contents, ExtensionTabUtil::INCLUDE_PRIVACY_SENSITIVE_FIELDS));
+ source_contents));
base::JSONWriter::Write(tab_value.get(), &tab_json);
}
@@ -202,7 +202,7 @@ void MessageService::OpenChannelToNativeApp(
std::string tab_json = "null";
if (source_contents) {
scoped_ptr<DictionaryValue> tab_value(ExtensionTabUtil::CreateTabValue(
- source_contents, ExtensionTabUtil::INCLUDE_PRIVACY_SENSITIVE_FIELDS));
+ source_contents));
base::JSONWriter::Write(tab_value.get(), &tab_json);
}
@@ -287,7 +287,7 @@ void MessageService::OpenChannelToTab(
std::string tab_json = "null";
if (source_contents) {
scoped_ptr<DictionaryValue> tab_value(ExtensionTabUtil::CreateTabValue(
- source_contents, ExtensionTabUtil::INCLUDE_PRIVACY_SENSITIVE_FIELDS));
+ source_contents));
base::JSONWriter::Write(tab_value.get(), &tab_json);
}
« no previous file with comments | « no previous file | chrome/browser/extensions/browser_event_router.h » ('j') | chrome/browser/extensions/browser_event_router.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698