chrome/browser/extensions/browser_event_router.h - Issue 11824004: Do not pass URLs in onUpdated events to extensions unless they have the

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/extensions/browser_event_router.h

Issue 11824004: Do not pass URLs in onUpdated events to extensions unless they have the (Closed) Base URL: http://git.chromium.org/chromium/src.git@master

Patch Set: Improve ExtensionApiTest.TabsNoPermissions test Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/extensions/api/messaging/message_service.cc ('k') | chrome/browser/extensions/browser_event_router.cc » ('j') | chrome/test/data/extensions/api_test/tabs/no_permissions/test.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/extensions/browser_event_router.h

diff --git a/chrome/browser/extensions/browser_event_router.h b/chrome/browser/extensions/browser_event_router.h

index 0f40c3605297529643b7bc4e7b7a2ac330926e9d..24aed8667b0d258b64762dd228dfe438230eeace 100644

--- a/chrome/browser/extensions/browser_event_router.h

+++ b/chrome/browser/extensions/browser_event_router.h

@@ -124,7 +124,7 @@ class BrowserEventRouter : public TabStripModelObserver,

// Packages |changed_properties| as a tab updated event for the tab |contents|

// and dispatches the event to the extension.

void DispatchTabUpdatedEvent(content::WebContents* contents,

- DictionaryValue* changed_properties);

+ scoped_ptr<DictionaryValue> changed_properties);

// Called to dispatch a deprecated style page action click event that was

// registered like: