Do not pass URLs in onUpdated events to extensions unless they have the

chrome/browser/extensions/extension_tab_util.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/extensions/extension_tab_util.h"
 
 #include "chrome/browser/extensions/api/tabs/tabs_constants.h"
 #include "chrome/browser/extensions/tab_helper.h"
 #include "chrome/browser/extensions/window_controller.h"
 #include "chrome/browser/net/url_fixer_upper.h"
@@ skipping 115 matching lines @@
 
   if (tab_strip) {
     WebContents* opener = tab_strip->GetOpenerOfWebContentsAt(tab_index);
     if (opener)
       result->SetInteger(keys::kOpenerTabIdKey, GetTabId(opener));
   }
 
   return result;
 }
 
+DictionaryValue* ExtensionTabUtil::ScrubTabValue(
+    const WebContents* contents,
+    const Extension* extension,
+    const DictionaryValue* update_info) {
+  DictionaryValue* scrubbed_info = update_info->DeepCopy();

[not at google - send to devlin, 2013/01/08 21:25:09]

it doesn't seem necessary to return a copy here; we could just modify
update_info in-place and make callers DeepCopy it if they want.

also, it's not necessarily update_info, so call tab_info?

[mvrable, 2013/01/09 01:46:59]

Done.

+
+  // Strip any sensitive data fields out of the update dictionary, if the
+  // extension does not have the tabs permission.
+  if (!extension ||
+      !extension->HasAPIPermissionForTab(ExtensionTabUtil::GetTabId(contents),
+                                         APIPermission::kTab)) {
+    scrubbed_info->Remove(keys::kUrlKey, NULL);
+    scrubbed_info->Remove(keys::kTitleKey, NULL);
+    scrubbed_info->Remove(keys::kFaviconUrlKey, NULL);
+  }
+
+  return scrubbed_info;
+}

[not at google - send to devlin, 2013/01/08 21:25:09]

It would be nice to avoid the duplication here and in CreateTabValue. Could you
remove the permissions check in there (always set the field), then scrub them
out in the CreateTabValue caller?

[mvrable, 2013/01/09 01:46:59]

Done, I think: do these changes look reasonable?

+
 bool ExtensionTabUtil::GetTabStripModel(const WebContents* web_contents,
                                         TabStripModel** tab_strip_model,
                                         int* tab_index) {
   DCHECK(web_contents);
   DCHECK(tab_strip_model);
   DCHECK(tab_index);
 
   for (BrowserList::const_iterator it = BrowserList::begin();
       it != BrowserList::end(); ++it) {
     TabStripModel* tab_strip = (*it)->tab_strip_model();
@@ skipping 121 matching lines @@
 
 // static
 extensions::WindowController* ExtensionTabUtil::GetWindowControllerOfTab(
     const WebContents* web_contents) {
   Browser* browser = chrome::FindBrowserWithWebContents(web_contents);
   if (browser != NULL)
     return browser->extension_window_controller();
 
   return NULL;
 }