src/ia32/lithium-codegen-ia32.cc - Issue 118233002: Handle Math.log(NaN) correctly in Crankshaft on Intel platforms.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/ia32/lithium-codegen-ia32.cc

Issue 118233002: Handle Math.log(NaN) correctly in Crankshaft on Intel platforms. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Created 7 years ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: src/ia32/lithium-codegen-ia32.cc

diff --git a/src/ia32/lithium-codegen-ia32.cc b/src/ia32/lithium-codegen-ia32.cc

index 5e947e5f454bba53f46bec7f499b803c4206be45..86118ebf6bdbeeb185b7aec0a762389dcc9da356 100644

--- a/src/ia32/lithium-codegen-ia32.cc

+++ b/src/ia32/lithium-codegen-ia32.cc

@@ -4156,7 +4156,7 @@ void LCodeGen::DoMathLog(LMathLog* instr) {

__ xorps(xmm_scratch, xmm_scratch);

__ ucomisd(input_reg, xmm_scratch);

__ j(above, &positive, Label::kNear);

- __ j(equal, &zero, Label::kNear);

+ __ j(not_carry, &zero, Label::kNear);

ExternalReference nan =

ExternalReference::address_of_canonical_non_hole_nan();

__ movsd(input_reg, Operand::StaticVariable(nan));

« no previous file with comments | « no previous file | src/x64/lithium-codegen-x64.cc » ('j') | no next file with comments »