Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(171)

Side by Side Diff: src/x64/lithium-codegen-x64.cc

Issue 118233002: Handle Math.log(NaN) correctly in Crankshaft on Intel platforms. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Created 7 years ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 the V8 project authors. All rights reserved. 1 // Copyright 2013 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 3708 matching lines...) Expand 10 before | Expand all | Expand 10 after
3719 3719
3720 3720
3721 void LCodeGen::DoMathLog(LMathLog* instr) { 3721 void LCodeGen::DoMathLog(LMathLog* instr) {
3722 ASSERT(instr->value()->Equals(instr->result())); 3722 ASSERT(instr->value()->Equals(instr->result()));
3723 XMMRegister input_reg = ToDoubleRegister(instr->value()); 3723 XMMRegister input_reg = ToDoubleRegister(instr->value());
3724 XMMRegister xmm_scratch = double_scratch0(); 3724 XMMRegister xmm_scratch = double_scratch0();
3725 Label positive, done, zero; 3725 Label positive, done, zero;
3726 __ xorps(xmm_scratch, xmm_scratch); 3726 __ xorps(xmm_scratch, xmm_scratch);
3727 __ ucomisd(input_reg, xmm_scratch); 3727 __ ucomisd(input_reg, xmm_scratch);
3728 __ j(above, &positive, Label::kNear); 3728 __ j(above, &positive, Label::kNear);
3729 __ j(equal, &zero, Label::kNear); 3729 __ j(not_carry, &zero, Label::kNear);
3730 ExternalReference nan = 3730 ExternalReference nan =
3731 ExternalReference::address_of_canonical_non_hole_nan(); 3731 ExternalReference::address_of_canonical_non_hole_nan();
3732 Operand nan_operand = masm()->ExternalOperand(nan); 3732 Operand nan_operand = masm()->ExternalOperand(nan);
3733 __ movsd(input_reg, nan_operand); 3733 __ movsd(input_reg, nan_operand);
3734 __ jmp(&done, Label::kNear); 3734 __ jmp(&done, Label::kNear);
3735 __ bind(&zero); 3735 __ bind(&zero);
3736 ExternalReference ninf = 3736 ExternalReference ninf =
3737 ExternalReference::address_of_negative_infinity(); 3737 ExternalReference::address_of_negative_infinity();
3738 Operand ninf_operand = masm()->ExternalOperand(ninf); 3738 Operand ninf_operand = masm()->ExternalOperand(ninf);
3739 __ movsd(input_reg, ninf_operand); 3739 __ movsd(input_reg, ninf_operand);
(...skipping 1846 matching lines...) Expand 10 before | Expand all | Expand 10 after
5586 FixedArray::kHeaderSize - kPointerSize)); 5586 FixedArray::kHeaderSize - kPointerSize));
5587 __ bind(&done); 5587 __ bind(&done);
5588 } 5588 }
5589 5589
5590 5590
5591 #undef __ 5591 #undef __
5592 5592
5593 } } // namespace v8::internal 5593 } } // namespace v8::internal
5594 5594
5595 #endif // V8_TARGET_ARCH_X64 5595 #endif // V8_TARGET_ARCH_X64
OLDNEW
« no previous file with comments | « src/ia32/lithium-codegen-ia32.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698