Fix handling of TYPE_CODE_NUMENTRY record when size large.

Fix handling of TYPE_CODE_NUMENTRY record when size large.

Fixes how (very) large size entries in the TYPE_CODE_NUMENTRY is
handled when reading bitcode. Makes sure that we con't call
vector.resize() with too large a value (replacing an allocation
exception with a parse error).

Also tries to clean up type modeling of bitcode indices (references to
values etc in the bitcode). Uses common type NaClBcIndexSize_t and
NaClRelBcIndexSize_t (defined in nacl) to describe these (32-bit)
values.

Note: We use cast truncation of 64-bit values to NaClBcIndexSize_t and
NaClRelBcIndexSize_t, since negative value indices are stored both as
32 and 64 bit values. The truncation cast handles this differences
correctly (and efficiently).

BUG= https://code.google.com/p/nativeclient/issues/detail?id=4195
R=stichnot@chromium.org

Committed: https://gerrit.chromium.org/gerrit/gitweb?p=native_client/pnacl-subzero.git;a=commit;h=74cd883a0b3ccb0920e5990ed860b1862ac73090

[Karl, 2015-06-18 22:20:05]

kschimpf@google.com changed reviewers:
+ jvoung@chromium.org, stichnot@chromium.org

[Jim Stichnoth, 2015-06-21 00:33:42]

https://codereview.chromium.org/1182323011/diff/20001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1182323011/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:495: // returns ICE::IceType_void.
Ice::IceType_void

https://codereview.chromium.org/1182323011/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:761: NaClBcIndexSize_t NextTypeId = 0;
Cool, I didn't know this was possible!

https://codereview.chromium.org/1182323011/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:797: Context->resizeTypeIDValues(std::min(Size,
(uint64_t)1000000));
do this without icky magic constants

https://codereview.chromium.org/1182323011/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:1470: void
ReportInvalidBinaryOp(Ice::InstArithmetic::OpKind Op, Ice::Type OpTy);
reportInvalidBinaryOp
?

https://codereview.chromium.org/1182323011/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:2909: void InstallGlobalNamesAndGlobalVarInitializers()
{
installGlobalNamesAndGlobalVarInitializers
?

[Karl, 2015-06-22 22:10:04]

https://codereview.chromium.org/1182323011/diff/20001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1182323011/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:495: // returns ICE::IceType_void.
On 2015/06/21 00:33:42, stichnot wrote:
> Ice::IceType_void

Done.

https://codereview.chromium.org/1182323011/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:761: NaClBcIndexSize_t NextTypeId = 0;
On 2015/06/21 00:33:42, stichnot wrote:
> Cool, I didn't know this was possible!

Acknowledged.

https://codereview.chromium.org/1182323011/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:797: Context->resizeTypeIDValues(std::min(Size,
(uint64_t)1000000));
On 2015/06/21 00:33:42, stichnot wrote:
> do this without icky magic constants

Done.

https://codereview.chromium.org/1182323011/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:1470: void
ReportInvalidBinaryOp(Ice::InstArithmetic::OpKind Op, Ice::Type OpTy);
On 2015/06/21 00:33:42, stichnot wrote:
> reportInvalidBinaryOp
> ?

Done.

https://codereview.chromium.org/1182323011/diff/20001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:2909: void InstallGlobalNamesAndGlobalVarInitializers()
{
On 2015/06/21 00:33:42, stichnot wrote:
> installGlobalNamesAndGlobalVarInitializers
> ?

Done, all all other capitalization cases I could find.

[Jim Stichnoth, 2015-06-22 22:48:09]

lgtm

https://codereview.chromium.org/1182323011/diff/40001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1182323011/diff/40001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:797: uint64_t DefaultLargeResizeValue = 1000000;
mark this const (or better, constexpr)

https://codereview.chromium.org/1182323011/diff/40001/unittest/IceParseTypesT...
File unittest/IceParseTypesTest.cpp (right):

https://codereview.chromium.org/1182323011/diff/40001/unittest/IceParseTypesT...
unittest/IceParseTypesTest.cpp:1: //===- unittest/NaClParseTypesTest.cpp
------------------------------------===//
You may want to add this file to FORMAT_BLACKLIST in Makefile.standalone.  I.e.,
add a new line:

FORMAT_BLACKLIST += ! -name NaClParseTypesTest.cpp

[Karl, 2015-06-23 18:05:05]

Committed patchset #4 (id:60001) manually as
74cd883a0b3ccb0920e5990ed860b1862ac73090 (presubmit successful).

[Karl, 2015-06-23 18:05:36]

https://codereview.chromium.org/1182323011/diff/40001/src/PNaClTranslator.cpp
File src/PNaClTranslator.cpp (right):

https://codereview.chromium.org/1182323011/diff/40001/src/PNaClTranslator.cpp...
src/PNaClTranslator.cpp:797: uint64_t DefaultLargeResizeValue = 1000000;
On 2015/06/22 22:48:09, stichnot wrote:
> mark this const (or better, constexpr)

Done.

https://codereview.chromium.org/1182323011/diff/40001/unittest/IceParseTypesT...
File unittest/IceParseTypesTest.cpp (right):

https://codereview.chromium.org/1182323011/diff/40001/unittest/IceParseTypesT...
unittest/IceParseTypesTest.cpp:1: //===- unittest/NaClParseTypesTest.cpp
------------------------------------===//
On 2015/06/22 22:48:09, stichnot wrote:
> You may want to add this file to FORMAT_BLACKLIST in Makefile.standalone. 
I.e.,
> add a new line:
> 
> FORMAT_BLACKLIST += ! -name NaClParseTypesTest.cpp

Done. Also fixed comment above.