pylib/gyp/input.py - Issue 1182323007: Make DependencyGraph.DeepDependencies() depth-first.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: pylib/gyp/input.py

Issue 1182323007: Make DependencyGraph.DeepDependencies() depth-first. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master

Patch Set: doc comment Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: pylib/gyp/input.py

diff --git a/pylib/gyp/input.py b/pylib/gyp/input.py

index 27718998605e31fef98b7729ba40a2fdf1f40365..c7efe99a122c0b736e1cc43683fe3f0b71d278f5 100644

--- a/pylib/gyp/input.py

+++ b/pylib/gyp/input.py

@@ -1662,8 +1662,8 @@ class DependencyGraphNode(object):

if dependency.ref is None:

continue

if dependency.ref not in dependencies:

- dependencies.add(dependency.ref)

dependency.DeepDependencies(dependencies)

+ dependencies.add(dependency.ref)

return dependencies

« no previous file with comments | « no previous file | test/dependencies/adso/all_dependent_settings_order.gyp » ('j') | no next file with comments »