Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(278)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: pylib/gyp/input.py

Issue 1182323007: Make DependencyGraph.DeepDependencies() depth-first. (Closed) Base URL: https://chromium.googlesource.com/external/gyp.git@master
Patch Set: add tests Created 5 years, 6 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | test/dependencies/adso/all_dependent_settings_order.gyp » ('j') | test/dependencies/adso/all_dependent_settings_order.gyp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: pylib/gyp/input.py
diff --git a/pylib/gyp/input.py b/pylib/gyp/input.py
index 27718998605e31fef98b7729ba40a2fdf1f40365..c7efe99a122c0b736e1cc43683fe3f0b71d278f5 100644
--- a/pylib/gyp/input.py
+++ b/pylib/gyp/input.py
@@ -1662,8 +1662,8 @@ class DependencyGraphNode(object):
if dependency.ref is None:
continue
if dependency.ref not in dependencies:
- dependencies.add(dependency.ref)
dependency.DeepDependencies(dependencies)
+ dependencies.add(dependency.ref)
return dependencies
« no previous file with comments | « no previous file | test/dependencies/adso/all_dependent_settings_order.gyp » ('j') | test/dependencies/adso/all_dependent_settings_order.gyp » ('J')

Powered by Google App Engine
This is Rietveld 408576698