Source/core/events/KeyboardEvent.h - Issue 1182313006: Populates sourceDevice attribute into KeyboardEvent

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/events/KeyboardEvent.h

Issue 1182313006: Populates sourceDevice attribute into KeyboardEvent (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 6 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « LayoutTests/fast/events/uievent-with-inputdevice-expected.txt ('k') | Source/core/events/KeyboardEvent.cpp » ('j') | Source/core/events/UIEvent.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/events/KeyboardEvent.h

diff --git a/Source/core/events/KeyboardEvent.h b/Source/core/events/KeyboardEvent.h

index bbe262322d4756d6b72b0c6b740063ecc9ffa7df..54b4985cb2f46a5981c8c4fdb8147d16a782bd5a 100644

--- a/Source/core/events/KeyboardEvent.h

+++ b/Source/core/events/KeyboardEvent.h

@@ -68,7 +68,7 @@ public:

void initKeyboardEvent(ScriptState*, const AtomicString& type, bool canBubble, bool cancelable, AbstractView*,

const String& keyIdentifier, unsigned location,

- bool ctrlKey, bool altKey, bool shiftKey, bool metaKey);

+ bool ctrlKey, bool altKey, bool shiftKey, bool metaKey, InputDevice* sourceDevice = nullptr);

const String& keyIdentifier() const { return m_keyIdentifier; }

const String& code() const { return m_code; }

« no previous file with comments | « LayoutTests/fast/events/uievent-with-inputdevice-expected.txt ('k') | Source/core/events/KeyboardEvent.cpp » ('j') | Source/core/events/UIEvent.idl » ('J')