Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(919)

Unified Diff: runtime/vm/compiler.cc

Issue 11823070: Increase deoptimization counter threshold to 16, cleanups. (Closed) Base URL: http://dart.googlecode.com/svn/branches/bleeding_edge/dart/
Patch Set: Created 7 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/compiler.cc
===================================================================
--- runtime/vm/compiler.cc (revision 16937)
+++ runtime/vm/compiler.cc (working copy)
@@ -44,15 +44,15 @@
DEFINE_FLAG(bool, loop_invariant_code_motion, true,
"Do loop invariant code motion.");
DEFINE_FLAG(bool, propagate_types, true, "Do static type propagation.");
-DEFINE_FLAG(int, deoptimization_counter_threshold, 5,
- "How many times we allow deoptimization before we disallow"
- " certain optimizations");
+DEFINE_FLAG(int, deoptimization_counter_threshold, 16,
+ "How many times we allow deoptimization before we disallow optimization.");
DEFINE_FLAG(bool, use_inlining, true, "Enable call-site inlining");
DEFINE_FLAG(bool, range_analysis, true, "Enable range analysis");
DEFINE_FLAG(bool, verify_compiler, false,
"Enable compiler verification assertions");
DECLARE_FLAG(bool, print_flow_graph);
DECLARE_FLAG(bool, print_flow_graph_optimized);
+DECLARE_FLAG(bool, trace_failed_optimization_attempts);
// Compile a function. Should call only if the function has not been compiled.
@@ -482,6 +482,8 @@
if (FLAG_trace_compiler) {
OS::Print("--> disabling optimizations for '%s'\n",
function.ToFullyQualifiedCString());
+ } else if (FLAG_trace_failed_optimization_attempts) {
+ OS::Print("Cannot optimize: %s\n", function.ToFullyQualifiedCString());
}
function.set_is_optimizable(false);
isolate->set_long_jump_base(base);
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698