Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Issue 11823061: GTTF: cherry-pick memalign/realloc mismatch debug code (Closed)

Created:
7 years, 11 months ago by Paweł Hajdan Jr.
Modified:
7 years, 11 months ago
CC:
chromium-reviews, dmikurube+memory_chromium.org
Visibility:
Public.

Description

GTTF: cherry-pick memalign/realloc mismatch debug code Especially ffmpeg may be prone to errors in this area. Googlers: see b/1397952 for reference. BUG=30715 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=177171

Patch Set 1 #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -2 lines) Patch
M third_party/tcmalloc/chromium/src/debugallocation.cc View 2 chunks +18 lines, -2 lines 2 comments Download

Messages

Total messages: 4 (0 generated)
Paweł Hajdan Jr.
7 years, 11 months ago (2013-01-16 00:40:58 UTC) #1
jar (doing other things)
https://codereview.chromium.org/11823061/diff/1/third_party/tcmalloc/chromium/src/debugallocation.cc File third_party/tcmalloc/chromium/src/debugallocation.cc (right): https://codereview.chromium.org/11823061/diff/1/third_party/tcmalloc/chromium/src/debugallocation.cc#newcode754 third_party/tcmalloc/chromium/src/debugallocation.cc:754: return mb->offset_ != 0; Why is this safe to ...
7 years, 11 months ago (2013-01-16 00:59:32 UTC) #2
Paweł Hajdan Jr.
https://codereview.chromium.org/11823061/diff/1/third_party/tcmalloc/chromium/src/debugallocation.cc File third_party/tcmalloc/chromium/src/debugallocation.cc (right): https://codereview.chromium.org/11823061/diff/1/third_party/tcmalloc/chromium/src/debugallocation.cc#newcode754 third_party/tcmalloc/chromium/src/debugallocation.cc:754: return mb->offset_ != 0; On 2013/01/16 00:59:32, jar wrote: ...
7 years, 11 months ago (2013-01-16 01:05:09 UTC) #3
jar (doing other things)
7 years, 11 months ago (2013-01-16 01:12:05 UTC) #4
lgtm

Powered by Google App Engine
This is Rietveld 408576698