Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1223)

Issue 11823052: Fix alarms_api_unittest.cc on GCC 4.6.3 linux 64 with -Werror=uninitialized: (Closed)

Created:
7 years, 11 months ago by Joao da Silva
Modified:
7 years, 11 months ago
CC:
chromium-reviews, Aaron Boodman, chromium-apps-reviews_chromium.org
Visibility:
Public.

Description

Fix alarms_api_unittest.cc on GCC 4.6.3 linux 64 with -Werror=uninitialized: ../../testing/gtest/include/gtest/gtest-printers.h:169:42: error: ‘level’ may be used uninitialized in this function [-Werror=uninitialized] ../../chrome/browser/extensions/api/alarms/alarms_api_unittest.cc:280:32: note: ‘level’ was declared here (introduced in http://crrev.com/176004) TBR=jyasskin Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176059

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/extensions/api/alarms/alarms_api_unittest.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 3 (0 generated)
Joao da Silva
7 years, 11 months ago (2013-01-10 13:54:27 UTC) #1
Joao da Silva
7 years, 11 months ago (2013-01-10 13:54:27 UTC) #2
jyasskin (not chrome)
7 years, 11 months ago (2013-01-10 18:50:15 UTC) #3
Thanks.
On Jan 10, 2013 5:54 AM, <joaodasilva@chromium.org> wrote:

> Reviewers: jyasskin,
>
> Description:
> Fix alarms_api_unittest.cc on GCC 4.6.3 linux 64 with
> -Werror=uninitialized:
>
> ../../testing/gtest/include/**gtest/gtest-printers.h:169:42: error:
> ‘level’ may be
> used uninitialized in this function [-Werror=uninitialized]
> ../../chrome/browser/**extensions/api/alarms/alarms_**api_unittest.cc:280:32:
> note:
> ‘level’ was declared here
>
> (introduced in http://crrev.com/176004)
>
> TBR=jyasskin
>
> Committed: https://src.chromium.org/**viewvc/chrome?view=rev&**
>
revision=176059<https://src.chromium.org/viewvc/chrome?view=rev&revision=176059>
>
> Please review this at
https://codereview.chromium.**org/11823052/<https://codereview.chromium.org/1...
>
> SVN Base:
svn://svn.chromium.org/chrome/**trunk/src<http://svn.chromium.org/chrome/trunk/src>
>
> Affected files:
>   M chrome/browser/extensions/api/**alarms/alarms_api_unittest.cc
>
>
> Index: chrome/browser/extensions/api/**alarms/alarms_api_unittest.cc
> diff --git a/chrome/browser/extensions/**api/alarms/alarms_api_**unittest.cc
> b/chrome/browser/extensions/**api/alarms/alarms_api_**unittest.cc
> index b9d1f04fb2c53b8c91f3c3d629ded1**5d60c14bf2..**
> 4460c298467d063034552e3aaf7d10**61e08ef400 100644
> --- a/chrome/browser/extensions/**api/alarms/alarms_api_**unittest.cc
> +++ b/chrome/browser/extensions/**api/alarms/alarms_api_**unittest.cc
> @@ -277,7 +277,7 @@ TEST_F(ExtensionAlarmsTest, CreateDelayBelowMinimum) {
>    const IPC::Message* warning = sink.GetUniqueMessageMatching(
>        ExtensionMsg_**AddMessageToConsole::ID);
>    ASSERT_TRUE(warning);
> -  content::ConsoleMessageLevel level;
> +  content::ConsoleMessageLevel level = content::CONSOLE_MESSAGE_**
> LEVEL_TIP;
>    std::string message;
>    ExtensionMsg_**AddMessageToConsole::Read(**warning, &level, &message);
>    EXPECT_EQ(content::CONSOLE_**MESSAGE_LEVEL_WARNING, level);
>
>
>

Powered by Google App Engine
This is Rietveld 408576698