mac: Pixel-based click detection for the tab close button

mac: Pixel-based click detection for the tab close button

BUG=168788
TEST=click close button in one of the corners not covered by the bitmap.
Tab doesn't close. Click center. Tab closes.

Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176223

[Nico, 2013-01-10 03:13:22]

ben: Is a pixel-perfect close button something that we want? Someone filed a bug
about it, and now that the image is a bit bigger than it used to be, the dead
area is relatively bigger too and it's easier to hit by accident. (I'm asking
you because you're in c/b/ui/views/tabs/OWNERS.)

sail: If ben things we should do this, please review the code.

[Nico, 2013-01-10 03:13:32]

On 2013/01/10 03:13:22, Nico wrote:
> ben: Is a pixel-perfect close button something that we want? Someone filed a
bug
> about it, and now that the image is a bit bigger than it used to be, the dead
> area is relatively bigger too and it's easier to hit by accident. (I'm asking
> you because you're in c/b/ui/views/tabs/OWNERS.)
> 
> sail: If ben things we should do this, please review the code.

*thinks

[Ben Goodger (Google), 2013-01-10 17:05:19]

sure we do stuff like this in viewsfe

[sail, 2013-01-10 17:57:18]

LGTM!

https://codereview.chromium.org/11823047/diff/1/chrome/browser/ui/cocoa/hover...
File chrome/browser/ui/cocoa/hover_close_button.mm (right):

https://codereview.chromium.org/11823047/diff/1/chrome/browser/ui/cocoa/hover...
chrome/browser/ui/cocoa/hover_close_button.mm:90: 0, 0, NSWidth([self bounds]),
NSHeight([self bounds]));
All our code already assumes that [self bounds] has a (0, 0) origin. I think you
can just use [self bounds] directly.

[Nico, 2013-01-10 23:26:51]

ben: Do you have a good suggestion who might be interested in doing this
particular thing in views?

https://codereview.chromium.org/11823047/diff/1/chrome/browser/ui/cocoa/hover...
File chrome/browser/ui/cocoa/hover_close_button.mm (right):

https://codereview.chromium.org/11823047/diff/1/chrome/browser/ui/cocoa/hover...
chrome/browser/ui/cocoa/hover_close_button.mm:90: 0, 0, NSWidth([self bounds]),
NSHeight([self bounds]));
On 2013/01/10 17:57:19, sail wrote:
> All our code already assumes that [self bounds] has a (0, 0) origin. I think
you
> can just use [self bounds] directly.

Done, thanks.

[commit-bot: I haz the power, 2013-01-10 23:28:07]

CQ is trying da patch. Follow status at
https://chromium-status.appspot.com/cq/thakis@chromium.org/11823047/4002