Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(618)

Issue 11823047: mac: Pixel-based click detection for the tab close button (Closed)

Created:
7 years, 11 months ago by Nico
Modified:
7 years, 11 months ago
CC:
chromium-reviews, sail+watch_chromium.org
Visibility:
Public.

Description

mac: Pixel-based click detection for the tab close button BUG=168788 TEST=click close button in one of the corners not covered by the bitmap. Tab doesn't close. Click center. Tab closes. Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176223

Patch Set 1 #

Total comments: 2

Patch Set 2 : sail #

Unified diffs Side-by-side diffs Delta from patch set Stats (+22 lines, -2 lines) Patch
M chrome/browser/ui/cocoa/hover_close_button.mm View 1 1 chunk +16 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/tabs/tab_view.mm View 1 chunk +6 lines, -2 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
Nico
ben: Is a pixel-perfect close button something that we want? Someone filed a bug about ...
7 years, 11 months ago (2013-01-10 03:13:22 UTC) #1
Nico
On 2013/01/10 03:13:22, Nico wrote: > ben: Is a pixel-perfect close button something that we ...
7 years, 11 months ago (2013-01-10 03:13:32 UTC) #2
Ben Goodger (Google)
sure we do stuff like this in viewsfe
7 years, 11 months ago (2013-01-10 17:05:19 UTC) #3
sail
LGTM! https://codereview.chromium.org/11823047/diff/1/chrome/browser/ui/cocoa/hover_close_button.mm File chrome/browser/ui/cocoa/hover_close_button.mm (right): https://codereview.chromium.org/11823047/diff/1/chrome/browser/ui/cocoa/hover_close_button.mm#newcode90 chrome/browser/ui/cocoa/hover_close_button.mm:90: 0, 0, NSWidth([self bounds]), NSHeight([self bounds])); All our ...
7 years, 11 months ago (2013-01-10 17:57:18 UTC) #4
Nico
ben: Do you have a good suggestion who might be interested in doing this particular ...
7 years, 11 months ago (2013-01-10 23:26:51 UTC) #5
commit-bot: I haz the power
7 years, 11 months ago (2013-01-10 23:28:07 UTC) #6

Powered by Google App Engine
This is Rietveld 408576698