android_webview/native/DEPS - Issue 11823046: Move content/components/web_contents_delegate_android to components/web_contents_delegate_android

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: android_webview/native/DEPS

Issue 11823046: Move content/components/web_contents_delegate_android to components/web_contents_delegate_android (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Fix DEPS, namespace content->components. Ready for review. Created 7 years, 11 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« no previous file with comments | « android_webview/java/src/org/chromium/android_webview/AwWebContentsDelegate.java ('k') | android_webview/native/android_webview_jni_registrar.cc » ('j') | chrome/browser/DEPS » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

2 "+content/public/browser",	2 "+content/public/browser",

3 "+ui/gfx",	3 "+ui/gfx",

4 "+ui/gl",	4 "+ui/gl",

	5 "+components", # For jni registers.
	joth 2013/01/10 22:21:53 Hmm dunno what granularity is best, but we should Hmm dunno what granularity is best, but we should either move this to aw/lib to avoid native/ dipping into random components, or just put "+components+ in the top level aw/DEPS (i.e. just say all components are fine for all of aw/ to use). boliu 2013/01/10 22:35:38 Do you mean moving android_webview_jni_registrar.c Show quoted text On 2013/01/10 22:21:53, joth wrote: > Hmm dunno what granularity is best, but we should either move this to aw/lib to > avoid native/ dipping into random components, or just put "+components+ in the > top level aw/DEPS (i.e. just say all components are fine for all of aw/ to use). > Do you mean moving android_webview_jni_registrar.cc to lib? Sounds reasonable.
5	6

6 # TODO(joth): Remove if we can move the compositor driver into ../browser/	7 # TODO(joth): Remove if we can move the compositor driver into ../browser/

7 "+third_party/skia/include",	8 "+third_party/skia/include",

8 ]	9 ]

OLD	NEW