Issue 11823042: Add args to DidCreate

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 11823042: Add args to DidCreate (Closed)

Created:
7 years, 11 months ago by noelallen1

Modified:
7 years, 11 months ago

Reviewers:
binji

CC:
chromium-reviews

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

More Reviews

Description

Add args to DidCreate Adds a optional dictionary passed to createNaClModule as a set of key value pairs to the DidCreate function. R=sbc@chromium.org,binji@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=176161

Patch Set 1 #

Total comments: 1

Patch Set 2 : Fix comment nit #

Created: 7 years, 11 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+10 lines, -1 line)			Patch
	M	native_client_sdk/src/examples/common.js	View	1	1 chunk	+10 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

binji

7 years, 11 months ago (2013-01-10 19:45:56 UTC) #2

lgtm

https://codereview.chromium.org/11823042/diff/1/native_client_sdk/src/example...
File native_client_sdk/src/examples/common.js (right):

https://codereview.chromium.org/11823042/diff/1/native_client_sdk/src/example...
native_client_sdk/src/examples/common.js:22: * @param {args} optional dictionary
of args to send to DidCreateInstance
nit: @param {Object} args ...

Expand Messages | Collapse Messages