Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(556)

Issue 1182303012: Componentize html_viewer's MessagePort (Closed)

Created:
5 years, 6 months ago by Ken Rockot(use gerrit already)
Modified:
5 years, 6 months ago
Reviewers:
jam
CC:
chromium-reviews, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Componentize html_viewer's MessagePort We should transition to using the same implementation in content, and this is the first step to doing that. BUG=361001 R=jam@chromium.org TBR=jochen@chromium.org (+WebKit DEPS) Committed: https://crrev.com/d3bd2cb5bc98903bbd9788ca01c0d1e9b15536ba Cr-Commit-Position: refs/heads/master@{#334914}

Patch Set 1 #

Patch Set 2 : OWNERS #

Patch Set 3 : exclude message_port from components gyp on ios #

Patch Set 4 : header-only target types: static_library -> none #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -206 lines) Patch
M components/components.gyp View 1 2 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/BUILD.gn View 2 chunks +1 line, -2 lines 0 comments Download
M components/html_viewer/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M components/html_viewer/blink_platform_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
D components/html_viewer/web_message_port_channel_impl.h View 1 chunk +0 lines, -45 lines 0 comments Download
D components/html_viewer/web_message_port_channel_impl.cc View 1 chunk +0 lines, -132 lines 0 comments Download
A + components/message_port.gypi View 1 chunk +6 lines, -6 lines 0 comments Download
A + components/message_port/BUILD.gn View 1 chunk +6 lines, -8 lines 0 comments Download
A components/message_port/DEPS View 1 chunk +6 lines, -0 lines 0 comments Download
A components/message_port/OWNERS View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
A + components/message_port/web_message_port_channel_impl.h View 2 chunks +5 lines, -5 lines 0 comments Download
A + components/message_port/web_message_port_channel_impl.cc View 3 chunks +3 lines, -3 lines 0 comments Download
M third_party/mojo/mojo_public.gyp View 1 2 3 3 chunks +29 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Ken Rockot(use gerrit already)
5 years, 6 months ago (2015-06-17 16:20:18 UTC) #1
jam
lgtm 1) please add owners file with me and you. every component should have its ...
5 years, 6 months ago (2015-06-17 17:11:02 UTC) #2
Ken Rockot(use gerrit already)
On 2015/06/17 17:11:02, jam wrote: > lgtm > > 1) please add owners file with ...
5 years, 6 months ago (2015-06-17 17:16:03 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182303012/20001
5 years, 6 months ago (2015-06-17 17:16:40 UTC) #6
jam
On 2015/06/17 17:16:03, Ken Rockot wrote: > On 2015/06/17 17:11:02, jam wrote: > > lgtm ...
5 years, 6 months ago (2015-06-17 18:11:44 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1182303012/60001
5 years, 6 months ago (2015-06-17 19:40:48 UTC) #11
commit-bot: I haz the power
Committed patchset #4 (id:60001)
5 years, 6 months ago (2015-06-17 20:57:02 UTC) #12
commit-bot: I haz the power
5 years, 6 months ago (2015-06-17 20:58:03 UTC) #13
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/d3bd2cb5bc98903bbd9788ca01c0d1e9b15536ba
Cr-Commit-Position: refs/heads/master@{#334914}

Powered by Google App Engine
This is Rietveld 408576698